Skip to content

Ciac 16249 improve docusign documentation and add get-event command#43770

Merged
lironcohen272 merged 10 commits intomasterfrom
CIAC-16249-Improve-Docusign-documentation
Apr 13, 2026
Merged

Ciac 16249 improve docusign documentation and add get-event command#43770
lironcohen272 merged 10 commits intomasterfrom
CIAC-16249-Improve-Docusign-documentation

Conversation

@lironcohen272
Copy link
Copy Markdown
Contributor

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-16249%20Improve%20Docusign%20documentation

Description

Improve Docusign documentation and add get-event command

@content-bot
Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@lironcohen272 lironcohen272 requested a review from kamalq97 April 5, 2026 18:19
@lironcohen272 lironcohen272 added ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Apr 5, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Apr 5, 2026
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for contributing to the Docusign pack. I've reviewed your changes and left a few notes to help polish the integration. The main items to address include using .get() for safer dictionary access in the Python code, updating the new command name to follow standard conventions, and adding the missing required fields to the pack metadata. Thanks again for your hard work!

Additionally, please address the following file-level notes:

  • Packs/Docusign/Integrations/Docusign/README.md: Ensure README is SDK-generated.
  • Packs/Docusign/pack_metadata.json: - The mandatory created key is missing from the pack metadata. Please add it with the pack's creation date.
  • The vendor name ('Docusign') must be included in the keywords list. Currently, the list is empty.

@kamalq97 please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Copy link
Copy Markdown
Contributor

@kamalq97 kamalq97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Minor changes needed.

@content-bot
Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@lironcohen272 lironcohen272 merged commit 270d7f0 into master Apr 13, 2026
21 checks passed
@lironcohen272 lironcohen272 deleted the CIAC-16249-Improve-Docusign-documentation branch April 13, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants