Retry backoff upstream by cyble-dev · Pull Request #43787 · demisto/content

cyble-dev · 2026-04-09T10:36:58Z

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

In Progress
Ready
In Hold - (Reason for hold)

Related Issues

Must have

Tests
Documentation

relates: https://jira-dc.paloaltonetworks.com/browse/CIAC-16491

…ry backoff

Restore cyble-vision-fetch-alerts, SAMPLE_ALERTS, get_event_format, and get_response retry naming; keep backoff only in get_data and get_all_services. Made-with: Cursor

content-bot · 2026-04-09T10:38:41Z

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @kamalq97 will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

content-bot · 2026-04-09T10:38:42Z

Hi @cyble-dev, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

content-bot · 2026-04-09T10:38:44Z

🤖 AI-Powered Code Review Available

Hi @kamalq97, you can leverage AI-powered code review to assist with this PR!

Available Commands:

@marketplace-ai-reviewer start review - Initiate a full AI code review
@marketplace-ai-reviewer re-review - Incremental review for new commits

kamalq97 · 2026-04-09T10:44:16Z

Hi @cyble-dev

Thank you for your contribution!

This PR does not yet have partner approval.

If you are a developer from the partner organization:

Please ensure the Partner ID is provided when filling the the Contribution Registration form.
- To find your Partner ID, log into the partner portal and locate the Account ID displayed at the top of the homepage; if you cannot access the portal or find the ID, please contact techpartnerportal@paloaltonetworks.com

If you are a member of our XSOAR Content development community:

Please confirm by commenting here or contacting me via the Cortex DFIR Community Slack.
- We will reach out to the partner and ask for their approval of the changes in this PR.

…erage - Add explicit fallback returns after retry loops in get_data and get_all_services - Mark unreachable fallbacks with pragma: no cover for coverage - Add unit tests for missing credentials, HTTP/JSON retry paths, and services retry Made-with: Cursor

content-bot · 2026-04-09T11:24:44Z

For the Reviewer: Trigger build request has been accepted for this contribution PR.

content-bot · 2026-04-09T11:24:50Z

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/8150997

marketplace-ai-reviewer · 2026-04-09T11:30:58Z

🤖 Analysis started. Please wait for results...

content-bot · 2026-04-09T11:34:06Z

Validate summary
The following errors were thrown as a part of this pr: DO106.
The following errors cannot be ignored: DO106.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.
The following errors don't run as part of the nightly flow and therefore can be force merged: DO106.

Verdict: PR can be force merged from validate perspective? ✅

marketplace-ai-reviewer · 2026-04-09T12:05:44Z

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

marketplace-ai-reviewer

Thanks for your contribution to the CybleEventsV2 pack! I've reviewed the PR and left a few suggestions to refine the new retry logic, specifically around failing immediately on format errors and expanding the test coverage to verify backoff behavior. Please also update the pack metadata to include the vendor name in the keywords and valid GitHub usernames, and ensure the release notes start with an approved prefix. Let me know if you have any questions!

Additionally, please address the following file-level notes:

Packs/CybleEventsV2/pack_metadata.json: - The vendor name (e.g., 'Cyble') must be included in the keywords list, which is currently empty.
The githubUser field is currently an empty list. Please provide a list of valid GitHub usernames (strings) to ensure the vendor receives notifications.

@kamalq97 please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

marketplace-ai-reviewer · 2026-04-09T12:05:41Z

Packs/CybleEventsV2/Integrations/CybleEventsV2/CybleEventsV2_test.py

+            result = self.client.get_all_services(self.test_api_key, self.test_url)
+        assert result == ["a"]
+        mock_sleep.assert_called()
+


Consider adding a test case that exhausts all retries to ensure the final exception is raised correctly.

marketplace-ai-reviewer · 2026-04-09T12:05:42Z

Packs/CybleEventsV2/Integrations/CybleEventsV2/CybleEventsV2.py

+                demisto.debug(f"Received services: {json.dumps(parsed['data'], indent=2)}")
+                return parsed["data"]
+
+            if attempt < len(backoffs):


Consider failing immediately on format errors instead of retrying.

marketplace-ai-reviewer · 2026-04-09T12:05:42Z

Packs/CybleEventsV2/Integrations/CybleEventsV2/CybleEventsV2_test.py

+        ):
+            result = self.client.get_data(self.test_service, input_params)
+
+        assert result == {"parsed": True}


Verify that the retry backoff was triggered.

marketplace-ai-reviewer · 2026-04-09T12:05:42Z

Packs/CybleEventsV2/ReleaseNotes/1_1_7.md

+
+##### CybleEvents v2
+
+- Added retry with backoff when fetch-incidents calls to the services or alerts API fail (initial attempt plus retries with delays of 5, 10, 20, 20, and 20 seconds).


The release note entry does not start with an approved prefix. Please auto-generate the release notes via demisto-sdk update-release-notes, and/or refer to the Release Notes Documentation.

Approved prefixes include Added support for, Improved implementation, Updated the, etc.

Consider rewording to something like:

- Improved implementation of `fetch-incidents` by adding retry with backoff when calls to the services or alerts API fail (initial attempt plus retries with delays of 5, 10, 20, 20, and 20 seconds).

cyble-dev added 3 commits April 9, 2026 15:46

added retry at 5,10,20,20,20 secs

fb4f12c

CybleEventsV2: bump pack to 1.1.7 and add release notes for fetch ret…

8a64663

…ry backoff

CybleEventsV2: limit changes to fetch-incidents API retry backoff

0fcf884

Restore cyble-vision-fetch-alerts, SAMPLE_ALERTS, get_event_format, and get_response retry naming; keep backoff only in get_data and get_all_services. Made-with: Cursor

content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Apr 9, 2026

content-bot changed the base branch from master to contrib/cyble-dev_Retry_backoff_upstream April 9, 2026 10:38

content-bot assigned kamalq97 Apr 9, 2026

content-bot requested a review from kamalq97 April 9, 2026 10:38

content-bot assigned DeanArbel Apr 9, 2026

content-bot added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner labels Apr 9, 2026

kamalq97 added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Apr 9, 2026

content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Apr 9, 2026

marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Apr 9, 2026

marketplace-ai-reviewer reviewed Apr 9, 2026

View reviewed changes

kamalq97 added the pending-contributor The PR is pending the response of its creator label Apr 9, 2026


		##### CybleEvents v2

		- Added retry with backoff when fetch-incidents calls to the services or alerts API fail (initial attempt plus retries with delays of 5, 10, 20, 20, and 20 seconds).

Conversation

cyble-dev commented Apr 9, 2026 • edited by marketplace-content-sync Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contributing to Cortex XSOAR Content

Status

Related Issues

Must have

Uh oh!

content-bot commented Apr 9, 2026

Uh oh!

content-bot commented Apr 9, 2026

Uh oh!

content-bot commented Apr 9, 2026

🤖 AI-Powered Code Review Available

Uh oh!

kamalq97 commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

content-bot commented Apr 9, 2026

Uh oh!

content-bot commented Apr 9, 2026

Uh oh!

marketplace-ai-reviewer commented Apr 9, 2026

Uh oh!

content-bot commented Apr 9, 2026

Uh oh!

marketplace-ai-reviewer commented Apr 9, 2026

Uh oh!

marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

Uh oh!

marketplace-ai-reviewer Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

marketplace-ai-reviewer Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

marketplace-ai-reviewer Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

marketplace-ai-reviewer Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cyble-dev commented Apr 9, 2026 •

edited by marketplace-content-sync

Loading

kamalq97 commented Apr 9, 2026 •

edited

Loading