ArenaStats TBC + Improvements#26
Open
MCribari wants to merge 4 commits into
Open
Conversation
**New Features/Improvements:** - **Map IDs:** Added correct Zone IDs for TBC Arenas (Nagrand, Blade's Edge and Ruins of Lordaeron). - **Icons:** Fixed a bug where icons where showing a "green square" instead of the class/spec icon. - **Minimap Button:** Fixed a bug where right clicking minimap panel (options menu) didnt worked and resulted in a error. - **Match Details:** New feature, now when you click on a match a pop-up window opens showing in-depth stats for that match (damage done, healing done, team name, etc). - **Delete Match:** New feature, now you can delete a specific match from the log with a button next to it. - **Test Data:** New feature, added a "Generate Test Data" button inside the options window, so you can see how it looks without the need to play a arena match. - **Live Updating:** Now every feature (Generate Test Data, Purge Database, Delete Match Button) will do what it should without the need to close and re-open the ArenaStats window to see the changes. - **Visual Change:** Added a more opaque window (85% alpha).
M cribari arena stats improvements
Owner
|
Hey @MCribari, thanks for this PR! The TBC support and new features (match details, damage/healing stats, delete functionality) look great. I found a few issues that should be fixed before merging: Critical (may prevent addon from loading)
Bugs
Multi-client support
Let me know if you have any questions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Features/Improvements: