Skip to content

ArenaStats TBC + Improvements#26

Open
MCribari wants to merge 4 commits into
denishamann:mainfrom
MCribari:main
Open

ArenaStats TBC + Improvements#26
MCribari wants to merge 4 commits into
denishamann:mainfrom
MCribari:main

Conversation

@MCribari
Copy link
Copy Markdown

@MCribari MCribari commented Feb 2, 2026

New Features/Improvements:

  • Map IDs: Added correct Zone IDs for TBC Arenas (Nagrand, Blade's Edge and Ruins of Lordaeron).
  • Icons: Fixed a bug where icons where showing a "green square" instead of the class/spec icon.
  • Minimap Button: Fixed a bug where right clicking minimap panel (options menu) didnt worked and resulted in a error.
  • Match Details: New feature, now when you click on a match a pop-up window opens showing in-depth stats for that match (damage done, healing done, team name, etc).
  • Delete Match: New feature, now you can delete a specific match from the log with a button next to it.
  • Test Data: New feature, added a "Generate Test Data" button inside the options window, so you can see how it looks without the need to play a arena match.
  • Live Updating: Now every feature (Generate Test Data, Purge Database, Delete Match Button) will do what it should without the need to close and re-open the ArenaStats window to see the changes.
  • Visual Change: Added a more opaque window (85% alpha).
{BCFFB3FF-E633-4FC1-B2FC-F6AB83F6B769}

**New Features/Improvements:**
- **Map IDs:** Added correct Zone IDs for TBC Arenas (Nagrand, Blade's Edge and Ruins of Lordaeron).
- **Icons:** Fixed a bug where icons where showing a "green square" instead of the class/spec icon.
- **Minimap Button:** Fixed a bug where right clicking minimap panel (options menu) didnt worked and resulted in a error.
- **Match Details:** New feature, now when you click on a match a pop-up window opens showing in-depth stats for that match (damage done, healing done, team name, etc).
- **Delete Match:** New feature, now you can delete a specific match from the log with a button next to it.
- **Test Data:** New feature, added a "Generate Test Data" button inside the options window, so you can see how it looks without the need to play a arena match.
- **Live Updating:** Now every feature (Generate Test Data, Purge Database, Delete Match Button) will do what it should without the need to close and re-open the ArenaStats window to see the changes.
- **Visual Change:** Added a more opaque window (85% alpha).
@denishamann
Copy link
Copy Markdown
Owner

Hey @MCribari, thanks for this PR! The TBC support and new features (match details, damage/healing stats, delete functionality) look great.

I found a few issues that should be fixed before merging:

Critical (may prevent addon from loading)

  • GUI.lua – Duplicate nested function definition around lines 2496–2519:
    function ArenaStats:SortClassSpecTable(a, b)
        -- comments...
    function ArenaStats:SortClassSpecTable(a, b)  -- nested duplicate
    The function is defined twice. Please remove the outer or duplicate one.

Bugs

  1. ArenaStats.lua - Duplicate line (~1013–1014):
    self.current["stats"]["enemyFaction"] = self:RaceToFaction(raceUpper)
    self.current["stats"]["enemyFaction"] = self:RaceToFaction(raceUpper)
  2. Version mismatch - Tooltip in DrawMinimapIcon shows 0.2.5, but TOC files list 0.3.0.
  3. Duplicate Toggle function – Defined in both ArenaStats.lua (~1563) and GUI.lua (~2685).

Multi-client support

  • Could you rebase on the latest main? The repo now uses .pkgmeta for multi-TOC packaging.
  • The main ArenaStats.toc should continue targeting Cata (40402), while ArenaStats_TBC.toc handles TBC clients.

Let me know if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants