Conversation
c208aa3 to
728bc6c
Compare
|
@hsanson sorry for noise in this PR (I had to get docker installed locally so I could run the tests). It's now ready to go. The problem I couldn't figure out was that, of course, |
hsanson
left a comment
There was a problem hiding this comment.
Looking good, thanks for the work. Would be great if you can add also help documentation to the PR:
- Add
ale-dprint-optionssection intoale.txtexplaining the possible configuration variables. - Add
ale-javascript-dprintsection toale-javascript.txtwhich points toale-dprint-options. See ale-javascript-deno and ale-javascript-cspell for example. - Repeat for every language supported by dprint (e.g. typescript, json, and markdown).
7cdaef3 to
7f99416
Compare
|
Thank you for your help getting this PR into shape. I've added all the languages which Also related: dprint/plugins#6 |
hsanson
left a comment
There was a problem hiding this comment.
Thanks for the extensive documentation. Just one small detail and this should be ready to merge.
hsanson
left a comment
There was a problem hiding this comment.
Thanks, good contribution and well documented.
This is attempt number 3. See https://github.com/dense-analysis/ale/pulls?q=is%3Apr+is%3Aclosed+dprint
I have changed to use
stdin. This is working well for me so far 💪