Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new cache invalidation mode,
CLEAR_TABLE, to ensure that all query condition cache entries for a table are invalidated in response to delete-like operations (such asDELETE,TRUNCATE, and certainMERGEactions) that can rewrite or remove entire row groups. The changes update the optimizer, logical and physical operators, and condition cache store to support this mode, and adjust tests to reflect the new invalidation semantics.Key changes:
Cache Invalidation Logic
CacheInvalidatorMode::CLEAR_TABLEto represent operations that require clearing all cache entries for a table, such asDELETE,TRUNCATE, and certainMERGEoperations. The optimizer now selects this mode for applicable statements. [1] [2] [3] [4]LogicalCacheInvalidatorto support theCLEAR_TABLEmode and updated deserialization logic accordingly. [1] [2] [3]Condition Cache Store
RemoveEntriesForTablemethod toConditionCacheStorethat deletes all cache entries for a given table, and integrated it into the physical invalidator's finalize logic for theCLEAR_TABLEmode. [1] [2] [3]RemoveEntriesForTablewhen inCLEAR_TABLEmode, ensuring all relevant cache entries are removed. [1] [2]Testing and Verification
DELETE,TRUNCATE, and related operations now clear all cache entries for the target table, and that cache invalidation remains correct after these operations. [1] [2] [3] [4] [5] [6]RemoveEntriesForTablemethod and for the newCLEAR_TABLEmode constructor ofLogicalCacheInvalidator. [1] [2]Other Improvements
These changes ensure that the query condition cache remains correct and consistent after operations that can affect the entire table, improving reliability and correctness.