Skip to content

Add conda and deno to packageManagerLookup#619

Merged
kbukum1 merged 2 commits intomainfrom
copilot/add-conda-deno-to-lookup
May 7, 2026
Merged

Add conda and deno to packageManagerLookup#619
kbukum1 merged 2 commits intomainfrom
copilot/add-conda-deno-to-lookup

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 7, 2026

conda and deno are valid dependabot-core ecosystems with published updater images (ghcr.io/dependabot/dependabot-updater-conda/deno) but were absent from packageManagerLookup, causing setImageNames to return unknown package manager for any job targeting either ecosystem.

Changes

  • internal/infra/run.go: Add "conda": "conda" and "deno": "deno" to packageManagerLookup in alphabetical order (between composer and devcontainers)
  • internal/infra/run_test.go: Add Test_setImageNames covering both new ecosystems and the unknown-manager error path

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 172.20.0.1
    • Triggering command: REDACTED, pid is -1 (packet block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Summary

Add conda and deno to the package manager lookup table in dependabot-cli so that jobs targeting these ecosystems can resolve their updater image. Both ecosystems are registered in dependabot/dependabot-core (require "dependabot/conda" and require "dependabot/deno") and have updater images published at ghcr.io/dependabot/dependabot-updater-conda and ghcr.io/dependabot/dependabot-updater-deno, but they are not in this CLI's lookup map.

Why

The packageManagerLookup map in internal/infra/run.go is what setImageNames uses to translate job.PackageManager into the updater image suffix. Anything not in this map causes:

return fmt.Errorf("unknown package manager: %s", params.Job.PackageManager)

After comparing against the full ecosystem list in dependabot-core, the only ecosystems missing from packageManagerLookup are conda and deno. (nix is already present.)

What to change

  1. Update packageManagerLookup in internal/infra/run.go (around the existing block with entries like "bazel": "bazel", "bun": "bun", "nix": "nix", etc.). Add the two missing entries while preserving the existing alphabetical ordering:

    "conda":          "conda",
    "deno":           "deno",

    (Confirm the upstream image suffix matches the key — for dependabot-core ecosystems that share a name with the published ghcr.io/dependabot/dependabot-updater-<suffix> image, this is a 1:1 mapping just like bun, cargo, nix, etc.)

  2. Search the rest of the repo for ecosystem enumerations that may also need updating. In particular check:

    • Any tests covering packageManagerLookup / setImageNames (e.g. internal/infra/*_test.go) — add coverage for conda and deno.
    • Docs/README listing supported ecosystems.
    • Any scenario fixtures or sample job files under testdata/ if they enumerate package managers.

    Update them to include conda and deno where relevant. If an enumeration is purely illustrative, no change is required — call this out in the PR body.

  3. Add or extend a unit test verifying that setImageNames resolves the correct image for conda and deno jobs (e.g. ghcr.io/dependabot/dependabot-updater-conda and ghcr.io/dependabot/dependabot-updater-deno). Follow the existing test style in the same package.

Required validation steps

Run the project's standard Go checks and ensure they pass:

go build ./...
go vet ./...
gofmt -l .            # should print nothing
go test ./...

If the repo has a Makefile with make test / make lint, prefer those targets.

Acceptance criteria

  • packageManagerLookup in internal/infra/run.go contains "conda": "conda" and "deno": "deno", placed in the existing alphabetical position.
  • A unit test exercises image resolution for both new ecosystems.
  • Any other in-repo ecosystem enumeration that should include all supported ecosystems is updated.
  • gofmt, go vet, and go test ./... all pass.

High-level PR description (use this in the PR body)

Extends the CLI's packageManagerLookup map to recognize two ecosystems already shipped by dependabot-core but missing here: conda and deno. Without these entries, setImageNames returns unknown package manager and jobs targeting Conda or Deno fail to resolve an updater image. Adds the two map entries, plus test coverage verifying both resolve to ghcr.io/dependabot/dependabot-updater-conda and ghcr.io/dependabot/dependabot-updater-deno. (nix is already supported, so it is intentionally not part of this change.)

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: Create proper PR on dependabot-actions using the project PR template and adding high level explanation in the PR for the for missing package managers. After comparison, I see that conda and deno seems to be missing. You can evaluate properly. I am sharing the full list from dependabot-core

require "dependabot/bazel"
require "dependabot/bun"
require "dependabot/bundler"
require "dependabot/cargo"
require "dependabot/composer"
require "dependabot/conda"
require "dependabot/deno"
require "dependabot/devcontainers"
require "dependabot/docker"
require "dependabot/docker_compose"
require "dependabot/dotnet_sdk"
require "dependabot/elm"
require "dependabot/github_actions"
require "dependabot/git_submodules"
require "dependabot/go_modules"
require "dependabot/gradle"
require "dependabot/helm"
require "dependabot/hex"
require "dependabot/julia"
require "dependabot/maven"
require "dependabot/nix"
require "dependabot/npm_and_yarn"
require "dependabot/nuget"
require "dependabot/opentofu"
require "dependabot/pre_commit"
require "dependabot/pub"
require "dependabot/pytho...

This pull request was created from Copilot chat.

Copilot AI changed the title [WIP] Add conda and deno to package manager lookup table Add conda and deno to packageManagerLookup May 7, 2026
Copilot finished work on behalf of kbukum1 May 7, 2026 21:27
Copilot AI requested a review from kbukum1 May 7, 2026 21:27
@kbukum1 kbukum1 marked this pull request as ready for review May 7, 2026 21:44
@kbukum1 kbukum1 requested review from a team as code owners May 7, 2026 21:44
@kbukum1 kbukum1 enabled auto-merge May 7, 2026 22:26
@kbukum1 kbukum1 added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit cacd441 May 7, 2026
183 of 187 checks passed
@kbukum1 kbukum1 deleted the copilot/add-conda-deno-to-lookup branch May 7, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants