Fix false positives for @import detection#9
Open
rmunch wants to merge 2 commits intodependents:mainfrom
Open
Conversation
Author
|
@XhmikosR I ran into an additional bug, and realize the |
Author
|
For now, I've patched precinct for my project to be able to register custom detectives similarly to what's mentioned here, and am pointing to a custom script that uses postcss-less, though I'm happy to make a PR if it would be helpful. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The detective was matching things like
@mediaqueries and@keyframeswhen looking for imports. This updates it to specifically match@imports. Thanks!