Merged
Conversation
annapo99
approved these changes
Jun 24, 2023
Member
annapo99
left a comment
annapo99
left a comment
There was a problem hiding this comment.
고생하셨습니다. 오늘 온라인 회의때 별 이상없으면 전부다 머지시키는걸로 해요 !
Comment on lines
+21
to
+30
| return SharedDesignSystemAsset.Images.crewRankingUpperBody.swiftUIImage | ||
|
|
||
| case .lowerBody: | ||
| return SharedDesignSystemAsset.Images.crewRankingLowerBody.swiftUIImage | ||
|
|
||
| case .lastPlace: | ||
| return SharedDesignSystemAsset.Images.crewRankingLastPlace.swiftUIImage | ||
|
|
||
| case .workoutCumulativeTime: | ||
| return SharedDesignSystemAsset.Images.crewRankingWorkoutCumulativeTime.swiftUIImage |
Member
There was a problem hiding this comment.
p1;
SharedDesignSystem이라면, PumpingImages 로 접근 가능합니다 !
Comment on lines
14
to
+20
| public extension Image { | ||
| static let avatar = SharedDesignSystemAsset.Images.avatar.swiftUIImage | ||
| static let avatarHead = SharedDesignSystemAsset.Images.avatarHead.swiftUIImage | ||
| static let arrow = SharedDesignSystemAsset.Images.arrow.swiftUIImage | ||
| static let arrowForPercentage = SharedDesignSystemAsset.Images.arrowForPercentage.swiftUIImage | ||
| static let boy = SharedDesignSystemAsset.Images.boy.swiftUIImage | ||
| static let dropdown = SharedDesignSystemAsset.Images.dropdown.swiftUIImage |
Member
There was a problem hiding this comment.
p5;
저희 이렇게 말고 PumpingImages로 접근해서 사용하는거 어떨까요 ? cc. @parkhj0423
일일이 추가하는 방식을 피하고 싶습니다 !
Comment on lines
+11
to
+29
| public struct CrewRankingCellView: View { | ||
| public let store: StoreOf<CrewRankingCellStore> | ||
|
|
||
| public init(store: StoreOf<CrewRankingCellStore>) { | ||
| self.store = store | ||
| } | ||
|
|
||
| public var body: some View { | ||
| WithViewStore(self.store, observe: { $0 }) { viewStore in | ||
| VStack { | ||
| Spacer() | ||
|
|
||
| CrewRankingType(rawValue: viewStore.title)?.backgroundImage | ||
| .resizable() | ||
| .frame(height: 180) | ||
| .offset(y: -40) | ||
| .overlay(content: { | ||
| VStack(alignment: .leading) { | ||
| rankingHeaderView(viewStore: viewStore) |
Member
There was a problem hiding this comment.
p5;
당장 수정사항은 아니지만, cell은 이제 design system이 아니라 feature에 있어야 합니다. 자세한 사항은 #95 에서 확인가능합니다. 천천히 리펙토링 해나가야할 부분이어서 미리 인지하고 있으면 도움 될것같아서 리뷰합니다 !
annapo99
changed the title
parkhj0423
approved these changes
Jun 24, 2023
Member
There was a problem hiding this comment.
ㅋㅋㅋㅋ 이거 이미지 넣는거 맞을까요 임시로 그린거같은데 ㅋㅋㅋㅋㅋㅋㅋ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 요약
📌 변경 사항
✅ PR check list
Linked Issue
close #