Skip to content

fix: quote bound animation for disjoint price range #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
behnam-deriv merged 1 commit into from
Mar 10, 2026
Merged

fix: quote bound animation for disjoint price range #467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions lib/src/deriv_chart/chart/basic_chart.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,14 +322,31 @@ class BasicChartState<T extends BasicChart> extends State<T>
maxQuote += 2;
}

if (!minQuote.isNaN && minQuote != bottomBoundQuoteTarget) {
if (minQuote.isNaN || maxQuote.isNaN) {
return;
}

// Snap bounds and skip tick animation when switching to a market with a
// disjoint price range, to avoid a long vertical-line artifact.
final bool rangeDisjoint =
maxQuote < bottomBoundQuoteTarget || minQuote > topBoundQuoteTarget;
if (rangeDisjoint) {
bottomBoundQuoteTarget = minQuote;
bottomBoundQuoteAnimationController.value = minQuote;
topBoundQuoteTarget = maxQuote;
topBoundQuoteAnimationController.value = maxQuote;
completeCurrentTickAnimation();
return;
}

if (minQuote != bottomBoundQuoteTarget) {
bottomBoundQuoteTarget = minQuote;
bottomBoundQuoteAnimationController.animateTo(
bottomBoundQuoteTarget,
curve: Curves.easeOut,
);
}
if (!maxQuote.isNaN && maxQuote != topBoundQuoteTarget) {
if (maxQuote != topBoundQuoteTarget) {
topBoundQuoteTarget = maxQuote;
topBoundQuoteAnimationController.animateTo(
topBoundQuoteTarget,
Expand Down