This repository was archived by the owner on Feb 16, 2024. It is now read-only.
fix: initial contract form#41
Draft
mayuran-deriv wants to merge 2 commits intoderiv-com:mainfrom
Draft
Conversation
| type ThintValuesAndMessages = Record<string, TTimeFrameConfig>; | ||
|
|
||
| const hintValuesAndMessages: ThintValuesAndMessages = { | ||
| minutes: { |
Contributor
There was a problem hiding this comment.
This should be created dynamically based on contracts_for response.
| const handleDurationToggle = () => setDurationOpen(prev => !prev); | ||
|
|
||
| const handleDurationSelect = (value: string) => setSelectedDuration(value); | ||
| const dropDownValues = [t('duration'), t('end time')]; |
Contributor
There was a problem hiding this comment.
Suggested change
| const dropDownValues = [t('duration'), t('end time')]; | |
| const dropDownValues = [t('Duration'), t('End time')]; |
| const DurationAndTimeout = () => { | ||
| const { t } = useTranslation(); | ||
| const [isDurationOpen, setDurationOpen] = useState(false); | ||
| const [selectedDuration, setSelectedDuration] = useState(t('duration')); |
Contributor
There was a problem hiding this comment.
We should be using a key to keep track of the selection. It we use the translated value it won't work properly when we switch language.
| import { useState } from 'react'; | ||
| import DurationIndex from './duration/DurationIndex'; | ||
|
|
||
| const DurationAndTimeout = () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| const DurationAndTimeout = () => { | |
| const DurationTypeDropdown = () => { |
| const DurationIndex = () => { | ||
| const { t } = useTranslation(); | ||
|
|
||
| const [selectedTimeFrame, setSelectedTimeFrame] = useState(t('minutes')); |
Contributor
There was a problem hiding this comment.
Same here. Use keys to keep track of the selection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.