fix: recalculate SSO Mappings #745
Open
+110
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new method to recalculate SSO group-to-role mappings for users in a tenant. The functionality allows updating user roles based on current SSO group mappings configuration, either for all SSO configurations in a tenant or for a specific SSO configuration.
Changes:
- Added
recalculate_sso_mappings()method to the SSO settings management API - Added comprehensive test coverage for the new method including error and success scenarios
- Updated sample application with usage example
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| descope/management/common.py | Added API path constant for the recalculate mappings endpoint |
| descope/management/sso_settings.py | Implemented the recalculate_sso_mappings() method with proper documentation and error handling |
| tests/management/test_sso_settings.py | Added comprehensive unit tests covering error cases and both optional parameter scenarios |
| samples/management/sso_sample_app.py | Added usage example demonstrating how to call the new method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)descope/management/sso_settings.py
descope/management/common.py
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recalculate SSO Mappings
https://github.com/descope/etc/issues/13548
Must