Support empty password when using local mysql for test#27
Open
zhangzhw8 wants to merge 2 commits intodesigncomputer:mainfrom
Open
Support empty password when using local mysql for test#27zhangzhw8 wants to merge 2 commits intodesigncomputer:mainfrom
zhangzhw8 wants to merge 2 commits intodesigncomputer:mainfrom
Conversation
zhangzhw8
commented
Apr 8, 2025
- Support empty password with warning log when using local mysql for test
- Fix some flake8 problem by the way.
Owner
|
@zhangzhw8 Thank you for your contribution! While the addition of support for empty passwords in local MySQL testing could be convenient, it raises some concerns:
We are currently reviewing the potential risks versus the benefits of this change. |
AdakHaddad
approved these changes
Jun 4, 2025
AdakHaddad
left a comment
There was a problem hiding this comment.
Same request here and much better with the warning👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.