Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the SatelliteDirectory configuration property by moving it from the Scintilla class to a new dedicated ScintillaNativeLibrary static class. This improves the API design by providing a clearer configuration point that users must set before the Scintilla type is first accessed. The change addresses issue #164 and increments the version to 6.1.1.
Key Changes:
- Introduced new
ScintillaNativeLibrarystatic class for native library configuration - Moved
SatelliteDirectoryproperty fromScintillatoScintillaNativeLibrary - Updated version from 6.1.0 to 6.1.1
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Scintilla.NET/ScintillaNativeLibrary.cs | New file providing dedicated configuration class for native library paths with clear documentation about initialization requirements |
| Scintilla.NET/Scintilla.cs | Removed SatelliteDirectory property and updated two references to use ScintillaNativeLibrary.SatelliteDirectory |
| Scintilla.NET/Scintilla.NET.csproj | Incremented version number from 6.1.0 to 6.1.1 for this patch release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.