Fix stale link activation from checkboxes#322
Closed
gazakov wants to merge 1 commit into
Closed
Conversation
|
|
Collaborator
|
Thanks! |
gazakov
marked this pull request as ready for review
July 22, 2026 10:07
Author
|
Thanks! I see this was fixed with a cleaner reuse of mouseMoveEvent. Closing as superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes telegramdesktop/tdesktop#30982.
When a checkbox dialog opens over a link without mouse movement, the old link can remain the active ClickHandler. The checkbox then presses and activates that stale handler on release.
This refreshes the handler from the current checkbox position before recording the press.
Tested by building the lib_ui target in the TDesktop 7.0.1 macOS arm64 Release configuration.