Add number of months instead of weeks if they exceed a certain amount#21
Open
sebastianmueller wants to merge 1 commit intodesktop-dart:masterfrom
Open
Add number of months instead of weeks if they exceed a certain amount#21sebastianmueller wants to merge 1 commit intodesktop-dart:masterfrom
sebastianmueller wants to merge 1 commit intodesktop-dart:masterfrom
Conversation
sebastianmueller
commented
Jun 17, 2020
sebastianmueller
commented
- default is 2 months as until that a timespan in weeks is sufficient (totally based on my personal gut feeling)
- calculates with a rough average of 365 / 12 = 30.42 days per month
* default is 2 months as until that a timespan in weeks is sufficient (totally based on my personal gut feeling) * calculates with a rough average of 365 / 12 = 30.42 days per month
|
We could use DateUtils.monthDelta + the printDuration of the difference between the endDate and the beginning of the month |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.