chore(web-ui): pin @phlix/ui v0.98.33 — ships S97's music redirect and S110's pager#571
Merged
Conversation
Ships TWO releases' worth of UI, not one: the pin was still on v0.98.31, so
v0.98.32 (S110's music paging) had been tagged but never rolled out to any
consumer. This delivers S110's pager AND S97's music-library redirect.
Verified in the emitted bundle rather than assumed. vs the previously committed
index chunk:
music-pager 0 -> 14 (S110's pager, previously undelivered)
`library` 2 -> 3
`music` 9 -> 11
and the S97 gate is present in minified form with its string literals hoisted:
var zo=`library`,Bo=`music`,Vo=`music`;
function Ho(e,t,n=!0){return e.name===Bo||e.name!==zo||!n||t!==Vo?n...
i.e. the loop guard, the library check, hasMusicRoute and the type check.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 1 medium |
| ErrorProne | 4 high |
| CodeStyle | 5 minor |
| Complexity | 17 medium |
🟢 Metrics 5023 complexity
Metric Results Complexity 5023
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #571 +/- ##
============================================
- Coverage 65.81% 65.80% -0.01%
Complexity 21055 21055
============================================
Files 657 657
Lines 66241 66241
============================================
- Hits 43595 43593 -2
- Misses 22646 22648 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolls the
/appSPA forward to @phlix/ui v0.98.33.This ships TWO releases, not one
The pin was still on v0.98.31, so v0.98.32 (S110's music paging) was tagged but never rolled out to
any consumer — both consumers were pinned behind it. This bump therefore delivers S110's pager and
S97's music-library redirect.
Verified in the emitted bundle, not assumed
@phlix/uiships by tag tarball withdist/committed, andnpm run buildinweb-ui/emits to../public/assets/app/, which is tracked — a pin bump without that output committed is inert. Measuredagainst the previously committed index chunk:
music-pager`library``music`and the S97 gate is present in minified form with its string literals hoisted by the minifier:
i.e. the loop guard, the
librarycheck,hasMusicRoute, and the type check.⚠ Note for anyone re-checking this: a probe for
name===\library`` finds nothing — the minifier hoiststhe literals into variables. Compare literal counts old-vs-new instead.
npm installwas used for the pin (the lockfile carries an integrity hash — never hand-edit the URL).