Skip to content

chore(web-ui): pin @phlix/ui v0.98.33 — ships S97's music redirect and S110's pager#571

Merged
detain merged 1 commit into
masterfrom
s97-ui-bump-v0.98.33
Jul 27, 2026
Merged

chore(web-ui): pin @phlix/ui v0.98.33 — ships S97's music redirect and S110's pager#571
detain merged 1 commit into
masterfrom
s97-ui-bump-v0.98.33

Conversation

@detain

@detain detain commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Rolls the /app SPA forward to @phlix/ui v0.98.33.

This ships TWO releases, not one

The pin was still on v0.98.31, so v0.98.32 (S110's music paging) was tagged but never rolled out to
any consumer
— both consumers were pinned behind it. This bump therefore delivers S110's pager and
S97's music-library redirect.

Verified in the emitted bundle, not assumed

@phlix/ui ships by tag tarball with dist/ committed, and npm run build in web-ui/ emits to
../public/assets/app/, which is tracked — a pin bump without that output committed is inert. Measured
against the previously committed index chunk:

probe old new
music-pager 0 14
`library` 2 3
`music` see commit +2

and the S97 gate is present in minified form with its string literals hoisted by the minifier:

var zo=`library`,Bo=`music`,Vo=`music`;
function Ho(e,t,n=!0){return e.name===Bo||e.name!==zo||!n||t!==Vo?n...

i.e. the loop guard, the library check, hasMusicRoute, and the type check.

⚠ Note for anyone re-checking this: a probe for name===\library`` finds nothing — the minifier hoists
the literals into variables. Compare literal counts old-vs-new instead.

npm install was used for the pin (the lockfile carries an integrity hash — never hand-edit the URL).

Ships TWO releases' worth of UI, not one: the pin was still on v0.98.31, so
v0.98.32 (S110's music paging) had been tagged but never rolled out to any
consumer. This delivers S110's pager AND S97's music-library redirect.

Verified in the emitted bundle rather than assumed. vs the previously committed
index chunk:
  music-pager   0 -> 14   (S110's pager, previously undelivered)
  `library`     2 -> 3
  `music`       9 -> 11
and the S97 gate is present in minified form with its string literals hoisted:
  var zo=`library`,Bo=`music`,Vo=`music`;
  function Ho(e,t,n=!0){return e.name===Bo||e.name!==zo||!n||t!==Vo?n...
i.e. the loop guard, the library check, hasMusicRoute and the type check.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 4 high · 18 medium · 5 minor

Alerts:
⚠ 27 issues (≤ 0 issues of at least minor severity)

Results:
27 new issues

Category Results
BestPractice 1 medium
ErrorProne 4 high
CodeStyle 5 minor
Complexity 17 medium

View in Codacy

🟢 Metrics 5023 complexity

Metric Results
Complexity 5023

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@detain
detain merged commit 5d464c5 into master Jul 27, 2026
15 of 16 checks passed
@detain
detain deleted the s97-ui-bump-v0.98.33 branch July 27, 2026 07:11
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.80%. Comparing base (3aaaac7) to head (54a13b0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #571      +/-   ##
============================================
- Coverage     65.81%   65.80%   -0.01%     
  Complexity    21055    21055              
============================================
  Files           657      657              
  Lines         66241    66241              
============================================
- Hits          43595    43593       -2     
- Misses        22646    22648       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant