Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes across the codebase, with a focus on enhancing authentication fallback using
.pgpass, updating test and build workflows, and improving code consistency and maintainability. The most significant changes are grouped below:Authentication and Connection Handling:
getConnectionWithPasswordfunction to fall back to.pgpassfor password retrieval if the password is not found in secure storage, improving user experience for connections configured outside the extension. [1] [2] [3]getConnectionWithPasswordto pass the specific database name, ensuring correct password resolution and database targeting in commands such as backup, restore, psql tool, and database tree operations. [1] [2] [3] [4] [5] [6]Testing and Build Workflow Updates:
actions/upload-artifactandactions/download-artifact, switched fromdocker-composetodocker compose, and added installation of the PostgreSQL client for integration tests. [1] [2] [3] [4]package.jsontest scripts for better compatibility with ESM and improved coverage reporting, and added a proxy file for test runner resolution ofConnectionManager. [1] [2]VS Code Tasks and UI Consistency:
.vscode/tasks.jsonand clarified task groupings for easier project builds in VS Code. [1] [2]Code Quality and Consistency:
ConnectionManager.tsfor consistency and maintainability. [1] [2] [3] [4] [5] [6]These changes collectively improve authentication robustness, developer experience, and code maintainability.