Feat/verification badge a11y#447
Merged
dev-fatima-24 merged 2 commits intoJun 1, 2026
Merged
Conversation
- Headline, subheadline, and primary CTA button - CTA triggers wallet connection flow; secondary link to /verify - Dark gradient background with feature pills for blockchain/healthcare context - Responsive layout using clamp() and flexWrap, above fold at 768px
- Replace text char icons with inline SVG CheckIcon/XIcon/SpinnerIcon - Use solid opaque backgrounds with white text for WCAG AA contrast (verified #15803d 5.74:1, not-verified/revoked #b91c1c 5.08:1) - not-found state now shows 'Not Verified' label (badge.notVerified key) - Add role=status and minHeight 2rem for accessibility and legibility - Add notVerified translation key to en.json and fr.json - Update tests: add i18n mock, cover new colors, SVG aria-hidden, role
|
@GreatShinro Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: redesign VerificationBadge with SVG icons and WCAG AA contrast
Summary
Redesigns
VerificationBadgeto meet accessibility and visual clarity requirements. Both verified and unverified states are now immediately distinguishable by icon shape, color, and text label — not color alone.Changes
frontend/src/components/VerificationBadge.jsx✓,✕,?) with inline SVGCheckIcon/XIcon/SpinnerIcon— sharp at any size,aria-hidden="true"to prevent screen reader duplication#ffffff) text, meeting WCAG AA contrast (≥4.5:1) in both light and dark modes:#15803d(green)#b91c1c(red)#1d4ed8(blue)not-foundstate now renders label "Not Verified" (badge.notVerified) instead of "No Records Found"role="status"for screen reader live region semanticsminHeight: 2rem(32px) to satisfy minimum legible size requirementfrontend/src/locales/en.json/fr.json"notVerified"translation key ("Not Verified"/"Non vérifié")frontend/src/components/VerificationBadge.test.jsxjest.mock('react-i18next', ...)with atresolver matching all badge keysminHeight,role="status",aria-hiddenon SVGsAcceptance criteria
minHeight: 2rem(32px)Testing
All 17 unit tests pass:
closes #286