fix(blog): heading anchor와 글 문체 정리#105
Conversation
PR 104 이후 구조에서 cherry-pick한 heading factory가 Next build 타입 검사에서 generic JSX 오류를 냈어요. 동작은 유지하고 React createElement 기반으로 렌더링해 heading tag 타입을 명확히 했어요.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b049fb808
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| aria-label="이 글의 목차" | ||
| > | ||
| <div className="h-full overflow-y-auto rounded-[var(--radius-md)] bg-[var(--color-grey-50)] p-4"> | ||
| <div className="rounded-[var(--radius-md)] bg-[var(--color-grey-50)] p-4"> |
There was a problem hiding this comment.
Restore scrolling for long TOCs
For longer posts on desktop (I checked existing posts such as posts/블로그-시스템-구축기/index.mdx with 41 headings and posts/알고리즘-시각화/index.mdx with 36), this fixed TOC can extend below the viewport and the lower links become unreachable because the scrollable h-full overflow-y-auto container and bottom constraint were removed. Please keep a viewport-bounded height/max-height with overflow-y-auto so all TOC entries remain accessible.
Useful? React with 👍 / 👎.
긴 블로그 글에서 desktop TOC가 viewport 아래로 넘치면 하단 항목에 접근할 수 없는 문제가 있었어요. native hash link 동작은 유지하고 TOC 영역에 bottom constraint와 내부 overflow scroll을 복원했어요.
변경 내용
blog/model/heading.ts로 분리의도
영향 범위
posts/맥북에어-m1-생활posts/실시간-CTR-파이프라인-구축기/meta.json검증
npm run lintnpm run lint:css:syntaxnpx vitest run blog/services/markdown-parser.test.ts blog/ui/components/TableOfContents.test.tsx blog/ui/mdx/components.test.tsx blog/services/publication-policy.test.tsgit diff --check master..HEADnpm run build체크리스트
codex/<task>)에서 진행함<type>: <한국어 설명>) 준수