-
-
Notifications
You must be signed in to change notification settings - Fork 12
Testing dependencies of critical packages (list) for AstroArch before updating #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added information about connecting via VNC and updated the mermaid diagram.
|
@sc74 I like this change, but I think the actual form is a half baked one. Why we don't do directly Blocking an update only because some of the deps have changed seems to be a lil excessive |
|
I understand your reasoning, but my approach is different. If, during the update test, dependencies break one of the packages in the defined list (packages you maintain), and you haven't recompiled them, then we block the updates and provide a notification explaining the reason (which you can modify as needed for reporting). Users will be less frustrated by a failed update (more opportunities for astronomical observations), and you'll have more time to fix it. What do you think? Another thing: the script saves a list of all the system's packages before the update. This could help us with debugging and perhaps also for a future script to automatically repair the system. |
| fi | ||
| done | ||
|
|
||
| if [ $found_risk -eq 1 ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a logical bug likely. In every loop you set found_risk to 0 and here, outside the pkg loop, you check the flag. If the last package will return found_risk=0, this won't block anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the variable should be initialized before the loops. Could you make the change? Otherwise, I'll look at it this evening after work.
|
I just fixed the variable positioning error and added the display of packages and dependencies with their conflicting versions. You can also modify the list of packages to check if you see a missing package |
No description provided.