Skip to content

fix(agents): allow Cursor product repository work#2410

Closed
devantler wants to merge 2 commits into
mainfrom
codex/agent-cursor-product-scope-2395
Closed

fix(agents): allow Cursor product repository work#2410
devantler wants to merge 2 commits into
mainfrom
codex/agent-cursor-product-scope-2395

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

The versioned Cursor loader still classified product-repository work as unavailable. Live behavior now disproves that deployment fact: app/cursor opened and delivered platform-template#111 from a cursor/* branch on 2026-07-22.

What changed

  • Treat product repositories as in scope when they are actually present in the cloud workspace.
  • Keep absent repositories as explicit capability gaps rather than a portfolio-wide prohibition.
  • Preserve the real cloud limits: no live-cluster access, local GPU/frame capture, or private operator notes.
  • Add a contract assertion so the obsolete product-work prohibition cannot return silently.

Verification

  • RED: portfolio-surveyor.test.sh failed with Cursor loader still treats its empty boot checkout as a product-repository boundary before the loader change.
  • GREEN: .claude/scripts/portfolio-surveyor.test.sh
  • bash -n .claude/scripts/portfolio-surveyor.test.sh
  • git diff --check

Fixes #2395

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

@devantler I’ll review the changes.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@devantler, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 2 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: a4d29eb6-b185-44ec-8b25-4594954e3f03

📥 Commits

Reviewing files that changed from the base of the PR and between da87921 and 9935bee.

📒 Files selected for processing (2)
  • .claude/loaders/cursor-daily-ai-engineer.md
  • .claude/scripts/portfolio-surveyor.test.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9935bee027

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +66 to +70
> - **Product repositories are in scope when present in the cloud workspace.** Do not mistake an
> empty monorepo submodule directory for a lane boundary: a current Cursor tick demonstrably opened
> and delivered a `cursor/*` PR in `devantler-tech/platform-template` on 2026-07-22. Resolve the
> current checkout against the contract's Portfolio map, work in that product repository, and push
> the branch to that repository's origin. A repository absent from the workspace is an honest

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Scan Cursor claims before enabling product work

When Cursor selects a product issue, it cannot self-assign, so until its draft exists the only visible claim is the pushed cursor/* branch. The checked .claude/agents/portfolio-surveyor.md still scans branches only for assigned-but-PR-less issues and filters them with grep '^claude/'; local siblings will therefore report that issue as actionable and can start a duplicate implementation during this window. Extend the surveyor and its contract test to discover cursor/* claims before widening Cursor to every product repository.

AGENTS.md reference: AGENTS.md:L362-L371

Useful? React with 👍 / 👎.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Closing this implementation after current-head Codex review found a valid coordination regression: widening the Cursor lane to product repositories increases the scope in which local siblings cannot see its pre-PR cursor/* claim.

The obvious surveyor-only fix was already rejected in #2300 because a branch without Cursor's unavailable assignment has no valid lease clock and can park work indefinitely. The durable, fail-closed prerequisite is the lane-neutral arbitration in #2302. This branch remains recoverable, but it must not be promoted ahead of that contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(ai-engineer): Cursor cloud loader falsely forbids submodule / product-repo work

1 participant