Fix: Zig version update#158
Open
octocamocoder47 wants to merge 2 commits intodevcontainers-extra:mainfrom
Open
Fix: Zig version update#158octocamocoder47 wants to merge 2 commits intodevcontainers-extra:mainfrom
octocamocoder47 wants to merge 2 commits intodevcontainers-extra:mainfrom
Conversation
Author
koralowiec
reviewed
Nov 19, 2025
| "proposals": [ | ||
| "latest", | ||
| "0.10.0" | ||
| "lts", |
Member
There was a problem hiding this comment.
Suggested change
| "lts", | |
| "latest", | |
| "stable", |
koralowiec
reviewed
Nov 19, 2025
| "0.12.1" | ||
| ], | ||
| "default": "latest", | ||
| "default": "lts", |
Member
There was a problem hiding this comment.
Suggested change
| "default": "lts", | |
| "default": "stable", |
koralowiec
reviewed
Nov 19, 2025
| then | ||
| # for latest we download the latest *release* version | ||
| DOWNLOAD_URL=$(curl -sSL $INDEX_URL | jq -r 'to_entries[0].value."'"$ARCH"'-linux".tarball') | ||
| elif [[ "$ZIG_VERSION" == "lts" ]]; then |
Member
There was a problem hiding this comment.
Suggested change
| elif [[ "$ZIG_VERSION" == "lts" ]]; then | |
| elif [[ "$ZIG_VERSION" == "stable" ]]; then |
koralowiec
reviewed
Nov 19, 2025
Comment on lines
18
to
+20
| | version | Select the Zig version you would like to install | string | latest | | ||
| | latest | This is latest version of zig which is still not released yet. Under development for developers use. You can use it as Beta release and post any issues on zig github repo.| | ||
| | lts | This is the Last released version of zig which is more stable and efficient.| |
Member
There was a problem hiding this comment.
We are keeping a single option here, you can reuse its description from src/zig/devcontainer-feature.json. Following example change from this comment:
Suggested change
| | version | Select the Zig version you would like to install | string | latest | | |
| | latest | This is latest version of zig which is still not released yet. Under development for developers use. You can use it as Beta release and post any issues on zig github repo.| | |
| | lts | This is the Last released version of zig which is more stable and efficient.| | |
| | version | Select the Zig version you would like to install. `stable` installs the latest stable release, while `latest` installs the most recent version (which may be a development release | string | stable | |
koralowiec
reviewed
Nov 19, 2025
| ], | ||
| "default": "latest", | ||
| "default": "lts", | ||
| "description": "Select the Zig version you would like to install" |
Member
There was a problem hiding this comment.
We provide more context here, for example:
Suggested change
| "description": "Select the Zig version you would like to install" | |
| "description": "Select the Zig version you would like to install. `stable` installs the latest stable release, while `latest` installs the most recent version (which may be a development release)" |
koralowiec
requested changes
Nov 19, 2025
Member
koralowiec
left a comment
koralowiec
left a comment
There was a problem hiding this comment.
Heyo!
I left few change requests. Generally, I don't see any info about Zig having LTS versions, so using lts may be misleading. I would propose to use stable instead
koralowiec
reviewed
Nov 19, 2025
| { | ||
| "name": "Zig (via ziglang.org)", | ||
| "id": "zig", | ||
| "version": "1.1.2", |
Member
There was a problem hiding this comment.
Version bump will be required
Suggested change
| "version": "1.1.3", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update README and JSON options for Zig version selection