chore: standardize action metadata validation in CI - #7
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92eb849f03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| status=0 | ||
|
|
||
| for action_file in notify-*/action.yml; do |
There was a problem hiding this comment.
The new validator claims to enforce metadata consistency across all actions, but it only iterates notify-*/action.yml. Any action added under a different directory name (or a root-level action.yml) will be skipped entirely, so CI can pass while that action uses a different runs.using/runs.main contract. This weakens the central guarantee introduced by this commit.
Useful? React with 👍 / 👎.
|
Closing as superseded by #10, which merged the action metadata validation workflow after fixing the actionlint CI failure. |
1 participant
Summary\n- add CI workflow to validate action metadata and GitHub Actions workflow syntax\n- add script to enforce
runs.using=node20,runs.main=dist/index.js, and dist entrypoint existence across all actions\n- fix trailing whitespace innotify-on-failure/action.ymland document validation flow in README files\n\n## Validation\n- ./scripts/validate-action-metadata.sh (pass)\n- local actionlint CLI not installed; added CI actionlint step via reviewdog/actionlint\n