Skip to content

sketch supermorecado#203

Merged
vincentsarago merged 10 commits intomainfrom
supermorecado
Mar 23, 2023
Merged

sketch supermorecado#203
vincentsarago merged 10 commits intomainfrom
supermorecado

Conversation

@vincentsarago
Copy link
Copy Markdown
Member

ref #202

Note: There will be a long way to go for full TMS support

Comment thread cogeo_mosaic/supermorecado.py Outdated
Comment thread cogeo_mosaic/supermorecado.py
Comment thread cogeo_mosaic/supermorecado.py Outdated
Comment thread cogeo_mosaic/supermorecado.py Outdated
) -> numpy.ndarray:
"""Burn geometries to Tiles."""
bounds = find_extrema(polys)
bounds = self.find_extrema(polys, truncate=truncate)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a truncate options because for sometimes you could want to create tiles outside the tms bbox

@vincentsarago vincentsarago marked this pull request as ready for review March 13, 2023 07:46
@vincentsarago
Copy link
Copy Markdown
Member Author

@AndrewAnnex I'll wait for your 👍 to merge this then we can look at the other part of the code that will need a change

@AndrewAnnex
Copy link
Copy Markdown
Contributor

AndrewAnnex commented Mar 13, 2023 via email

@vincentsarago
Copy link
Copy Markdown
Member Author

with titiler yet though as some updates are needed there to accept other TMSs.

Yes a lot needs to happen for this

@jlaura
Copy link
Copy Markdown

jlaura commented Mar 20, 2023

This is awesome to see. What is the best way to assist on this? I see that reviews are good to go and tests are in for WebMercator. Is it appropriate to test with another TMS and start to see where else breakages occur?

@vincentsarago
Copy link
Copy Markdown
Member Author

👋 sorry I've been busy on other projects.
I think this PR is good to go, but yeah adding test for other TMS would be great 🤷 but this can be in another PR later

@jlaura
Copy link
Copy Markdown

jlaura commented Mar 21, 2023

@vincentsarago no worries - we are all juggling a ton!

This PR LGTM! 🚀

Once this merges I'll get some tests for other TMSes PRed in.

@vincentsarago vincentsarago merged commit 3dad872 into main Mar 23, 2023
@vincentsarago vincentsarago deleted the supermorecado branch March 23, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants