Skip to content

fix: keep chart rewrite and middleware annotations above user overrides - #581

Merged
pantierra merged 1 commit into
mainfrom
fix/ingress-chart-annotation-precedence
Jul 23, 2026
Merged

fix: keep chart rewrite and middleware annotations above user overrides#581
pantierra merged 1 commit into
mainfrom
fix/ingress-chart-annotation-precedence

Conversation

@pantierra

@pantierra pantierra commented Jul 23, 2026

Copy link
Copy Markdown
Contributor
  • Merge ingress annotations as a map so chart-owned rewrite/middleware keys win over ingress.annotations
  • User override of Traefik router.entrypoints still works
  • Unit test: chart middlewares win over user router.middlewares

Note: anyone who intentionally overrode rewrite-target or router.middlewares via ingress.annotations will need to use another mechanism after this.

@claude

claude Bot commented Jul 23, 2026

Copy link
Copy Markdown

Claude finished @pantierra's task in 2m 2s —— View job


I'll analyze this and get back to you.


💰 Estimated review cost: $0.73 · 2m02s · 22 turns

@pantierra pantierra changed the title fix(helm): keep chart rewrite and middleware annotations above user overrides fix: keep chart rewrite and middleware annotations above user overrides Jul 23, 2026
@pantierra
pantierra force-pushed the fix/ingress-chart-annotation-precedence branch 5 times, most recently from a5afedd to f297afa Compare July 23, 2026 22:31
@pantierra
pantierra force-pushed the fix/ingress-chart-annotation-precedence branch from f297afa to 0af066f Compare July 23, 2026 22:36
@pantierra
pantierra merged commit eff2fae into main Jul 23, 2026
4 checks passed
@pantierra
pantierra deleted the fix/ingress-chart-annotation-precedence branch July 23, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant