Task/fix newsletter api request body - #270
Merged
Merged
Conversation
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the embeddable newsletter subscription component so the subscription request body reliably includes list and tag (supporting both data-attribute embedding and direct React prop usage), and updates the related documentation/changeset.
Changes:
- Update newsletter component to include
list/tagin the submit payload and adjust email handling. - Tweak newsletter README (props table).
- Add a changeset for
@devgateway/dvz-ui-react(patch).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/dvz-ui/src/embeddable/newsletter/README.md | Removes the Redux-managed email prop row from the generated docs. |
| packages/dvz-ui/src/embeddable/newsletter/index.jsx | Updates newsletter submit/input logic and (intended) request body parameters. |
| .changeset/tall-groups-behave.md | Declares a patch release noting the list/tag request body fix. |
ralvarez-dg
approved these changes
Jul 23, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix newsletter api request body
Type of change
fix:)feat:)BREAKING CHANGE:)refactor:/chore:)docs:)Affected package(s)
@devgateway/dvz-ui-react@devgateway/wp-react-libexampleonly (no changeset needed)Checklist
pnpm changeset) for any change to a published packagepnpm buildpasses locallypnpm --filter @devgateway/* typecheckpasses