Skip to content

fix : fix newsletter omitting some props in ssr #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timothygachengo merged 1 commit into from
Jul 23, 2026
Merged

fix : fix newsletter omitting some props in ssr #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/pink-adults-turn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@devgateway/dvz-ui-react": patch
---

Fix newsletter props to allow them to be parsed in SSR context
19 changes: 15 additions & 4 deletions packages/dvz-ui/src/embeddable/newsletter/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,30 @@ const Index = (props) => {
const {
status,
editing,
"data-list": list,
"data-list": dataList,
list: propList,
"data-placeholder": placeholder = "enter your email address",
"data-success-message": successmessage = "Thanks",
"data-failure-message": failuremessage = "Something didn't go well",
Comment thread
timothygachengo marked this conversation as resolved.
"data-label": label = "Send",
"data-tag": tag,
"data-tag": dataTag,
tag: propTag,
} = props;


const list = dataList ?? propList
const tag = dataTag ?? propTag

const [email, setEmail] = React.useState("")

const submit = () => {
if (!expresion.test(email)) return
props.onSubmit({email, list, tag})

const payload = {email}
if (list != null) payload.list = list
if (tag != null) payload.tag = tag

props.onSubmit(payload)
}


Expand All @@ -47,7 +58,7 @@ const Index = (props) => {
onChange={(e, target) => setEmail(target.value)}
iconPosition='left'
placeholder={placeholder}/>
<Button disabled={!valid} primary onClick={e => submit()}>{label}</Button>
<Button disabled={!valid} primary onClick={submit}>{label}</Button>
</div>
{message}
</div>
Expand Down
Loading