chore(forensics): refresh types after mono details JSONB + reason cleanup#20
Merged
Conversation
caballeto
force-pushed
the
chore/forensics-details-field
branch
from
0c59161 to
e4847ab
Compare
…anup Picks up two changes from devhelmhq/mono#316: - IncidentStateTransitionDto gains a `details: Record<string, unknown>` field. User-driven transitions carry `details.source = "public-api"`; pipeline-driven ones carry `details.source = "pipeline"`. Lets the forensics command distinguish actor without forking the reason vocabulary. - The transition `reason` description switches from the seven-name proposal ("rule_matched | confirmation_met | …") to the five verbs the engine actually writes ("trigger | confirm | resolve | auto_clear | reopen"). No code referenced `manually_resolved` directly — it was only echoed in the schema description string — so this is a doc/comment-level refresh. Pure regen: docs/openapi/monitoring-api.json copied from mono main, then `npm run build` (typegen + zodgen + descgen). No hand edits. Made-with: Cursor
caballeto
force-pushed
the
chore/forensics-details-field
branch
from
e4847ab to
43dfb44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picks up the type changes from devhelmhq/mono#316, which adds a
details JSONBcolumn toincident_state_transitionsand collapses transition reasons to five short verbs (the originalmanually_resolvedwas a parallel reason value; it's nowreason="resolve"+details.source="public-api").IncidentStateTransitionDto.details: Record<string, unknown>added. Surfaced in the timeline / trace / monitor-transition responses. Distinguishes actor (pipelinevspublic-api) without forking the reason vocabulary.reasondescription updated from the seven-name design proposal (rule_matched | confirmation_met | …) to the five verbs the engine actually writes (trigger | confirm | resolve | auto_clear | reopen).What's in this PR
Pure regen — no hand edits:
docs/openapi/monitoring-api.jsoncopied from mono main.npm run build(=typegen+zodgen+descgen+tsc+oclif manifest).Three generated files updated; no source code changed.
Dependency
Depends on devhelmhq/mono#316 reaching main. The
spec-propagateworkflow would normally do this regen automatically — opening manually so we can release CLI in the next batch without waiting for the cron.Test plan
npm run lintcleannpm run typecheckcleannpm run buildclean (typegen + zodgen + descgen + tsc + oclif manifest)npm test— 870 tests passMade with Cursor