fix: dispatch surface_published after npm publish for verify timing#5
Merged
Merged
Conversation
The publish-verify workflow in the monorepo was triggered by surface_release, which fires after build but before npm publish. This caused ETARGET errors because the package wasn't on npm yet. Add a surface_published dispatch step that fires immediately after npm publish succeeds, so the monorepo can verify the live package. Made-with: Cursor
caballeto
added a commit
that referenced
this pull request
Apr 20, 2026
…s from spec, enable noUncheckedIndexedAccess Phase 2 cleanup across the CLI codegen pipeline: - Wire `parseSingle`/`parsePage`/`parseCursorPage` response validation through `apiGetSingle` so commands no longer rely on `data as T` casts in `checkedFetch` (Bug #5, P1 strict-fail on response envelopes). - Generate `MATCH_RULE_TYPES`, `WEBHOOK_EVENT_TYPES`, and `STATUS_PAGE_VISIBILITIES` from the OpenAPI spec via `spec-facts.generated.ts` instead of hardcoding them in `yaml/zod-schemas.ts` and command flags (Bug #14). - Drive the imperative `--visibility` flag for `status-pages` from the spec-derived `STATUS_PAGE_VISIBILITIES` tuple instead of a hardcoded one-element array (Bugs #1, #2). - Drop the `@ts-nocheck` pragma on `api-zod.generated.ts` (now preprocessed for Zod-3 compatibility during generation) and fix the type fallout in command files. - Enable `noUncheckedIndexedAccess: true` in `tsconfig.json` and refactor index-loop sites in YAML resolver / validator / interpolation / child-reconciler / parser / state show to satisfy it. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
surface_publisheddispatch step in thepublishjob, immediately afternpm publishsucceedssurface-publish-verify.ymlat the right time (after the package is live on npm)surface_releasewhich fires after build but before npm publish, causingETARGETfailuresContext
Companion PRs:
surface-publish-verify.ymlfromsurface_release→surface_published+ adds multi-surface supportTest plan
Made with Cursor