chore(tests): add forensics ops to run-sdk harness#14
Merged
Conversation
The Forensics resource (design 046) was added to the SDK in v0.6.0 but the test harness was never updated to dispatch the 5 ops, which caused the mono parity check (TestHarnessCompleteness) to fail after the release. Adds dispatch cases for: - forensics.incident-timeline → client.forensics.incidentTimeline - forensics.check-trace → client.forensics.checkTrace - forensics.policy-snapshot → client.forensics.policySnapshot - forensics.monitor-rule-evaluations → client.forensics.monitorRuleEvaluations - forensics.monitor-transitions → client.forensics.monitorTransitions The paginated ops accept an optional JSON-encoded filter object as a second arg, matching the existing monitors.results / monitors.versions convention. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
caballeto
added a commit
that referenced
this pull request
May 5, 2026
…ing (#16) `Monitor.currentStatus` is computed by the probe pipeline and isn't populated on a freshly-created monitor, so a fresh dev who logs it straight after `client.monitors.create()` sees `undefined`. Wrap the generated `MonitorDto` so the field is surfaced as `string | null` with a doc comment that explains the timing, and update the README quickstart with a one-line note + `?? 'PENDING'` display pattern so the example doesn't read as broken. Round-2 DevEx friction P2 #14. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 5 dispatch cases in
test/run-sdk.mjsfor the newforensicsresource (design 046, shipped in v0.6.0):forensics.incident-timeline→client.forensics.incidentTimelineforensics.check-trace→client.forensics.checkTraceforensics.policy-snapshot→client.forensics.policySnapshotforensics.monitor-rule-evaluations→client.forensics.monitorRuleEvaluationsforensics.monitor-transitions→client.forensics.monitorTransitionsPaginated ops accept an optional JSON-encoded filter as the second arg (same convention as
monitors.results/monitors.versions).Why
The Forensics resource was added to the SDK in v0.6.0 but the harness was never updated, causing the monorepo parity check (
TestHarnessCompleteness::test_sdk_js_harness_complete) to fail after the release (failed run).Paired with corresponding harness fixes in
devhelmhq/sdk-pythonand a parity-classification PR indevhelmhq/mono.Test plan
client.forensics.{incidentTimeline,checkTrace,policySnapshot,monitorRuleEvaluations,monitorTransitions}are all functions on a real instanceTestHarnessCompleteness::test_sdk_js_harness_complete) pass locally with this branch checked out as the SDK sourceMade with Cursor