feat: adds a publishing system to validate job post submissions#52
Open
aaronarduino wants to merge 1 commit intodevict:mainfrom
Open
feat: adds a publishing system to validate job post submissions#52aaronarduino wants to merge 1 commit intodevict:mainfrom
aaronarduino wants to merge 1 commit intodevict:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I decided to give a go at adding post validation to help cut down on spam submissions(#50). My thinking was that it might be better to create a published flag in the db rather than a validation flag since that would allow better semantics around validating email addresses in the future. This would require job posts to be published before they go live.
Things changed:
published_atdb column tocreated_atin db.publishedbool andpublished_atnullable timestamp cols to db.Updatebutton toPublish.Publishon the edit page is clicked updatepublishedcol to true andpublished_atto current timestamp, then save job.Let me know if you think anything should be improved or changed. Thanks!