Update 07_functions_on_subdomains.ipynb #2832
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the sign on the coupling between pressure and stress, such that the correct physical boundary conditions are respected.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
EdCaunt
reviewed
Jan 23, 2026
Contributor
EdCaunt
left a comment
EdCaunt
left a comment
There was a problem hiding this comment.
Looks good. Just need to fix the linting and make sure the notebook CI passes. I believe you may also want to update the final two figures, since the elastic portion will have reversed polarity.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2832 +/- ##
==========================================
- Coverage 78.99% 78.95% -0.04%
==========================================
Files 248 248
Lines 50837 50837
Branches 4392 4392
==========================================
- Hits 40158 40139 -19
- Misses 9879 9900 +21
+ Partials 800 798 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the sign on the coupling between pressure and stress, such that the correct physical boundary conditions are respected.