Skip to content

Fix type Exif to have property Thumbnail #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovell merged 1 commit into from
Dec 12, 2025
Merged

Fix type Exif to have property Thumbnail #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions exiv2/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,3 @@ As the type information is incomplete for a few tags (e.g. the exif-reader autom
The website itself is generated based on the output of a tool called `taglist` (part of the Exiv2 project),
so if the website vanishes, we can still use this tool. (But need some investment of time to build it
from the C++ sources)


3 changes: 1 addition & 2 deletions exiv2/generate.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const tagsjs = `/**
${tagGroups.map(generateTagGroup).join('\n')}
`
writeFileSync(join(wd, '..', 'tags.js'), tagsjs);
//console.log(tagsjs);

const getType = (group, tag, type) => {
if (numberArrayTags[group]?.includes(tag)) return 'number[]';
Expand Down Expand Up @@ -105,7 +104,7 @@ declare namespace exif {
type Exif = {
bigEndian: boolean
${groups.map((group) => `${group}?: Partial<${group}Tags>`).join('\n ')}
ThumbnailTags?: Partial<ImageTags>
Thumbnail?: Partial<ImageTags>
}

${tagGroups.map(generateTagGroupTypes).join('\n\n')}
Expand Down
2 changes: 1 addition & 1 deletion index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ declare namespace exif {
Photo?: Partial<PhotoTags>
Iop?: Partial<IopTags>
GPSInfo?: Partial<GPSInfoTags>
ThumbnailTags?: Partial<ImageTags>
Thumbnail?: Partial<ImageTags>
}

type ImageTags = Record<string, GenericTag> & {
Expand Down