fix: improve DevCard export rendering#595
Merged
Aditya948351 merged 3 commits intoJun 13, 2026
Merged
Conversation
Collaborator
|
Replacing html2canvas with html-to-image sounds like a solid fix for the export rendering issue! The before/after screenshots are super helpful. I'll review this shortly. |
Collaborator
|
Thanks for the great contribution! We just merged another PR that modified DevCard.tsx, so this had some conflicts. But don't worry, I manually resolved the conflicts for you and am merging it right now! Great work with the html-to-image fix! |
602e754
into
devpathindcommunity-india:master
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #566
Summary
Fixes DevCard download rendering issues where exported images did not match the browser view.
Changes
Before
After
Result
Downloaded DevCard now closely matches the browser-rendered card.