Skip to content

fix: stabilize devcard typing and effects#598

Closed
saurabhhhcodes wants to merge 2 commits into
devpathindcommunity-india:masterfrom
saurabhhhcodes:feat/devcard-enhancements-530
Closed

fix: stabilize devcard typing and effects#598
saurabhhhcodes wants to merge 2 commits into
devpathindcommunity-india:masterfrom
saurabhhhcodes:feat/devcard-enhancements-530

Conversation

@saurabhhhcodes

Copy link
Copy Markdown
Contributor

Summary\n- tighten DevCard typing and hook state handling\n- reduce effect churn and keep profile card interactions stable\n\n## Validation\n- manual review of the component diff\n- no additional app-wide changes

@Aditya948351

Aditya948351 commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Awesome, stabilizing the DevCard typing and effects is much needed. I'll review the code soon. Thanks!

@Aditya948351 Aditya948351 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! This is much more than just stabilizing typings, adding the social links and profile completion UI to the DevCard is an awesome feature. The code looks solid and cleans up the effect churn perfectly. Approved!

@Aditya948351

Aditya948351 commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Hi! We just merged PR #597 (real-time Firestore sync). It completely rewrote the state logic inside DevCard.tsx. Because of this, your PR now has massive merge conflicts. Could you please pull the latest master, resolve the conflicts, and implement your awesome new UI features WITHOUT deleting the image loading or download functionality? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants