ci(fuzz): fix AFL runtime build and gate PRs on deep-fuzz#137
Merged
Conversation
The deep-fuzz-afl leg has failed every nightly since it landed (#99): cargo-afl 0.18.2's `cargo install` already builds the AFL++ runtime, so the explicit `cargo afl config --build` panics with "AFL LLVM runtime was already built". Pass `--force` as the tool's own error message instructs. Make fuzzing a merge gate instead of an after-the-fact nightly alarm: - run the workflow on pull_request to main (60s smoke per target; nightly keeps 120s, workflow_dispatch duration still wins) - PR runs seed from the accumulated main corpus but never minimize or upload it back — corpus persistence stays a nightly concern - add a fuzz-gate summary job over both engine matrices, giving branch protection one stable required-check name that fails when any leg fails or is cancelled - cancel superseded PR runs via a per-event concurrency group Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
deep-fuzz-aflleg has failed every nightly since it landed in #99 — it never had a green scheduled run. All 12 AFL jobs die inBuild AFL++ runtime:cargo install cargo-afl(0.18.2) already leaves the runtime built for the active rustc, so the explicit plaincargo afl config --buildpanics on "already built". The 13 libFuzzer jobs are unaffected (all green).On top of that, the workflow only ran on
schedule/workflow_dispatch, so fuzz breakage was discovered the morning after merge instead of blocking the PR that introduced it.Fix
cargo afl config --build --force— rebuilds unconditionally, as the tool's own error message instructs; covers both the pre-built and not-built cases.Fuzzing as a merge gate
pull_requesttrigger (targetingmain): PRs run a 60s-per-target smoke fuzz on both engines; nightly keeps 120s andworkflow_dispatchduration still takes precedence.maincorpus (the restore step already filters--branch main) but skip minimize + upload, so corpus compounding stays a nightly concern.fuzz-gatesummary job over both engine matrices — one stable check name for branch protection instead of 25 per-target contexts that drift when targets are added.if: always()so a failed/cancelled leg reports as a red ✗ instead of leaving the required check stuck at "Expected".After this merges, branch protection on
maingainsfuzz-gateas a required status check alongsideNix Flake Check.Verification
actionlintclean (also enforced by the pre-commit hook and thecesr-actionlintflake check).nix flake checkpassed via the pre-push hook.fuzz-gatecheck running on this very PR exercises the fixed AFL leg end-to-end.🤖 Generated with Claude Code