chore(ssrf-guard): bump demos to 3.3.0 - #109
Merged
Merged
Conversation
3.3.0 carries two security fixes found by the first JVM <-> JS parity audit: redirect hops now get the same checks as the first request (via a single core definition rather than three adapters each improvising a different subset), and the LLM tool-input scanner stopped dropping non-http(s) schemes and protocol-relative URLs before the policy saw them. The jdkhttp demo needed more than a version bump. 3.3.0 makes SsrfGuardedHttpClient refuse a delegate that follows redirects itself, because it now follows and re-validates them internally — so the demo's comment, "Wrap any HttpClient", had become false. It is replaced with the one constraint that now applies and why it exists. The code did not need to change: HttpClient.newBuilder().build() is already Redirect.NEVER. Verified against the real artifacts rather than assumed — 3.3.0 was on Maven Central by the time this ran, and all seven demos build green, jdkhttp included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssrf-guard 3.3.0 반영.
3.3.0이 담는 것
첫 JVM ↔ JS 정합성 감사에서 나온 보안 수정 2건:
RedirectGuard)로. 특히jdkhttp는 홉을 아무것도 검증하지 않고 있었습니다.jdkhttp 데모는 버전만 올리면 안 됐습니다
3.3.0의
SsrfGuardedHttpClient는 리다이렉트를 스스로 따라가는 delegate를 거부합니다. 자기가 따라가며 재검증하기 때문입니다. 그래서 데모의 주석 "Wrap any HttpClient" 가 거짓이 됐습니다.주석을 지금 적용되는 제약 하나와 그 이유로 교체했습니다. 코드는 바꿀 필요가 없었습니다 —
HttpClient.newBuilder().build()는 이미Redirect.NEVER입니다.검증
추정이 아니라 실제 아티팩트로 확인했습니다. 이 작업 시점에 3.3.0이 Maven Central에 올라와 있었고, 데모 7종 전부 그린입니다:
루트 README는 Maven Central 배지라 자동 갱신됩니다.