fix: gecko data_collection_permissions declaration (AMO requirement) - #21
Merged
Conversation
AMO validation rejects new submissions without a data-collection declaration. We collect nothing, so required: [none]. Chrome ignores the browser_specific_settings block entirely. Verified locally with addons-linter: 0 errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMO now hard-requires a
data_collection_permissionsdeclaration inbrowser_specific_settings.gecko— upload failed validation without it. We collect nothing →required: ["none"]. Chrome ignores the block. Pre-validated locally with mozilla/addons-linter: 0 errors (3 warnings are from harness.html, which isn't in the zip). AMO 필수 선언 추가 — 수집 없음.