Skip to content

feat: update Theme.kt to use CyberScheme with dark background and pur…#4

Open
Deadendev wants to merge 2 commits into
devxvoid:mainfrom
Deadendev:feature/kai-9000-ui-upgrade
Open

feat: update Theme.kt to use CyberScheme with dark background and pur…#4
Deadendev wants to merge 2 commits into
devxvoid:mainfrom
Deadendev:feature/kai-9000-ui-upgrade

Conversation

@Deadendev

Copy link
Copy Markdown
Contributor

…ple primary for Kai 9000 UI

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CyberScheme color palette in Theme.kt. The current implementation introduces syntax errors due to literal newline characters and orphaned code that will prevent compilation. The reviewer identified these issues and provided a code suggestion to use darkColorScheme instead of lightColorScheme to correctly reflect the dark background colors and ensure Material 3 compatibility.


private val CyberScheme = lightColorScheme(
primary = Color(0xFF007D89),
private val CyberScheme = lightColorScheme(\n primary = Color(0xFF6200EE),\n secondary = Color(0xFF7257A8),\n tertiary = Color(0xFF0F766E),\n background = Color(0xFF121212),\n surface = Color(0xFF1E1E1E),\n surfaceVariant = Color(0xFF24211F),\n onPrimary = Color.White,\n onSecondary = Color.White,\n onTertiary = Color.White,\n onBackground = Color.White,\n onSurface = Color.White,\n onSurfaceVariant = Color(0xFF475569),\n outline = Color(0xFFCBD5E1)\n)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The CyberScheme definition is syntactically incorrect. It contains literal \n characters and closes the function call prematurely on the same line, which will cause compilation errors as the subsequent lines (52-64) become orphaned code. Additionally, since this is intended to be a dark theme (background 0xFF121212), it should use darkColorScheme instead of lightColorScheme to ensure correct default behavior for Material 3 components and accessibility. Please replace the entire block with a properly formatted definition and remove the redundant trailing lines.

Suggested change
private val CyberScheme = lightColorScheme(\n primary = Color(0xFF6200EE),\n secondary = Color(0xFF7257A8),\n tertiary = Color(0xFF0F766E),\n background = Color(0xFF121212),\n surface = Color(0xFF1E1E1E),\n surfaceVariant = Color(0xFF24211F),\n onPrimary = Color.White,\n onSecondary = Color.White,\n onTertiary = Color.White,\n onBackground = Color.White,\n onSurface = Color.White,\n onSurfaceVariant = Color(0xFF475569),\n outline = Color(0xFFCBD5E1)\n)
private val CyberScheme = darkColorScheme(
primary = Color(0xFF6200EE),
secondary = Color(0xFF7257A8),
tertiary = Color(0xFF0F766E),
background = Color(0xFF121212),
surface = Color(0xFF1E1E1E),
surfaceVariant = Color(0xFF24211F),
onPrimary = Color.White,
onSecondary = Color.White,
onTertiary = Color.White,
onBackground = Color.White,
onSurface = Color.White,
onSurfaceVariant = Color(0xFF475569),
outline = Color(0xFFCBD5E1)
)

@Deadendev Deadendev left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗝️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant