feat: update Theme.kt to use CyberScheme with dark background and pur…#4
feat: update Theme.kt to use CyberScheme with dark background and pur…#4Deadendev wants to merge 2 commits into
Conversation
…ple primary for Kai 9000 UI
There was a problem hiding this comment.
Code Review
This pull request updates the CyberScheme color palette in Theme.kt. The current implementation introduces syntax errors due to literal newline characters and orphaned code that will prevent compilation. The reviewer identified these issues and provided a code suggestion to use darkColorScheme instead of lightColorScheme to correctly reflect the dark background colors and ensure Material 3 compatibility.
|
|
||
| private val CyberScheme = lightColorScheme( | ||
| primary = Color(0xFF007D89), | ||
| private val CyberScheme = lightColorScheme(\n primary = Color(0xFF6200EE),\n secondary = Color(0xFF7257A8),\n tertiary = Color(0xFF0F766E),\n background = Color(0xFF121212),\n surface = Color(0xFF1E1E1E),\n surfaceVariant = Color(0xFF24211F),\n onPrimary = Color.White,\n onSecondary = Color.White,\n onTertiary = Color.White,\n onBackground = Color.White,\n onSurface = Color.White,\n onSurfaceVariant = Color(0xFF475569),\n outline = Color(0xFFCBD5E1)\n) |
There was a problem hiding this comment.
The CyberScheme definition is syntactically incorrect. It contains literal \n characters and closes the function call prematurely on the same line, which will cause compilation errors as the subsequent lines (52-64) become orphaned code. Additionally, since this is intended to be a dark theme (background 0xFF121212), it should use darkColorScheme instead of lightColorScheme to ensure correct default behavior for Material 3 components and accessibility. Please replace the entire block with a properly formatted definition and remove the redundant trailing lines.
| private val CyberScheme = lightColorScheme(\n primary = Color(0xFF6200EE),\n secondary = Color(0xFF7257A8),\n tertiary = Color(0xFF0F766E),\n background = Color(0xFF121212),\n surface = Color(0xFF1E1E1E),\n surfaceVariant = Color(0xFF24211F),\n onPrimary = Color.White,\n onSecondary = Color.White,\n onTertiary = Color.White,\n onBackground = Color.White,\n onSurface = Color.White,\n onSurfaceVariant = Color(0xFF475569),\n outline = Color(0xFFCBD5E1)\n) | |
| private val CyberScheme = darkColorScheme( | |
| primary = Color(0xFF6200EE), | |
| secondary = Color(0xFF7257A8), | |
| tertiary = Color(0xFF0F766E), | |
| background = Color(0xFF121212), | |
| surface = Color(0xFF1E1E1E), | |
| surfaceVariant = Color(0xFF24211F), | |
| onPrimary = Color.White, | |
| onSecondary = Color.White, | |
| onTertiary = Color.White, | |
| onBackground = Color.White, | |
| onSurface = Color.White, | |
| onSurfaceVariant = Color(0xFF475569), | |
| outline = Color(0xFFCBD5E1) | |
| ) |
…ple primary for Kai 9000 UI