feat(oidc): Add flag to forward all logs, even if allowedGroups is set#4668
Open
peschmae wants to merge 1 commit intodexidp:masterfrom
Open
feat(oidc): Add flag to forward all logs, even if allowedGroups is set#4668peschmae wants to merge 1 commit intodexidp:masterfrom
peschmae wants to merge 1 commit intodexidp:masterfrom
Conversation
Member
|
Hello @peschmae and thanks for the PR! We are planning to go from the custom connector group filtering logic to a policy solution. The idea is briefly discussed here. https://github.com/dexidp/dex/blob/master/docs/enhancements/cel-expressions-2026-02-28.md |
Signed-off-by: Mathias Petermann <mathias.petermann@swisscom.com>
aaae157 to
a18554d
Compare
Contributor
Author
|
Updated the branch to fix linting issues. @nabokihms Oh that sounds awesome! :) I guess this won't be merged then? |
Member
|
As of today, we don't have anything more structured than thoughts in the DEP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Currently if the
allowedGroupsflag is set in a oidc connector, only the matching groups are kept in the claim. This was introduced in #3074Shortly afterwards the regex filter for groups was introduced in #3063 which is applied first.
This change adds a new config flag
forwardAllGroupswhich keeps the (filtered) groups in the claim, even ifallowedGroupsis used.What this PR does / why we need it
We are running dex, and want to limit the groups which can login to a Authentication group (eg. SERVICE_GROUP), but in the service, we also need a list of Authorization groups (eg. SERVICE_GROUP_ADMIN, SERVICE_GROUP_VIEWER). Currently we would need to have all groups in the
allowedGroupslist to check for the in the service behind dex. If you have a large list of Authorization groups (or a dynamic list), it's not possible to have all of them forwarded without updating the dex config each time a new one is added.With this new field, it would be possible to configure
allowedGroupsto limit who can login, and then also use theclaimModification.filterGroupClaimsto only send the relevant groups to the backend service.It is implemented in a backwards compatible way, so that the behaviour doesn't change unless the user enabled the
forwardAllGroupsflag.Special notes for your reviewer