add knockback handler#1156
Draft
FDUTCH wants to merge 1 commit intodf-mc:masterfrom
Draft
Conversation
Contributor
|
I suggest combining HandleEntityAttack and this handler into a single version. Perhaps also specifying the cause of the knockback (e.g. KnockBackCause) |
Contributor
Author
I like the idea of having as much information as possible when handling events, but it seems that the guys here prefer simplicity, so I think we can avoid adding KnockBackCause (as I described in discord, there is a way to get knockback cause) |
Contributor
Author
|
@Sandertv any suggestions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not every knockback is a result of player been punched, so I think we need ability to control every knockback