feat(blocks): Implement cobweb#1189
Conversation
| vel[0] *= 0.25 | ||
| vel[1] *= 0.05 | ||
| vel[2] *= 0.25 |
There was a problem hiding this comment.
From reading the wiki, this logic only applies to players. We should probably have some sort of way to handle this for all entity types too
There was a problem hiding this comment.
Also worth noting https://minecraft.wiki/w/Weaving can reduce the movement speed, so something will need to be done to make that possible to implement, even if you don't actually implement that here
There was a problem hiding this comment.
yep, I plan on implementing weaving in another PR
There was a problem hiding this comment.
Does it not make sense to put the base in this PR so you're not re-doing all the work you've already done? Technically this physics behaviour isn't correct as it stands. It works for normal players, but it's different for other entities and even more different for item entities. Have you tested to see if this works correctly with jumping behaviour too?
the player can move at a speed of about 25% of the normal walking speed, and their jumping height is severely reduced
From the wiki, but could just mean the same 25% reduction
There was a problem hiding this comment.
Does it not make sense to put the base in this PR so you're not re-doing all the work you've already done? Technically this physics behaviour isn't correct as it stands. It works for normal players, but it's different for other entities and even more different for item entities. Have you tested to see if this works correctly with jumping behaviour too?
the player can move at a speed of about 25% of the normal walking speed, and their jumping height is severely reduced
From the wiki, but could just mean the same 25% reduction
I don't see the point of implementing the base of weaving in this PR, if that's what you mean by base?
There was a problem hiding this comment.
I mean the base of having different multipliers for velocity, not specifically for weaving
3 participants
No description provided.