Remove unnecessary nil check in PalettedStorage.compact()#1193
Open
HashimTheArab wants to merge 1 commit intodf-mc:masterfrom
Open
Remove unnecessary nil check in PalettedStorage.compact()#1193HashimTheArab wants to merge 1 commit intodf-mc:masterfrom
HashimTheArab wants to merge 1 commit intodf-mc:masterfrom
Conversation
The palette field is never nil in practice, so the nil check is unnecessary and can be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplified the nil check logic in the
PalettedStorage.compact()method by removing a redundant nil guard condition.Key Changes
storage.palette == nilcheck from the compact method's initial guard clausestorage.palette.Len() == 0check is sufficient to handle both nil and empty palette cases, as callingLen()on a nil palette would panic anyway, indicating the palette should never be nil at this point in the codeImplementation Details
The change assumes that
storage.paletteis guaranteed to be non-nil whencompact()is called, making the explicit nil check unnecessary. This simplifies the code while maintaining the same safety guarantees through theLen() == 0check.https://claude.ai/code/session_01TSiou5rfpek63r8pCRyqoi