world/viewer.go: Allow for more complex entity animations to be played#940
Merged
world/viewer.go: Allow for more complex entity animations to be played#940
Conversation
Sandertv
reviewed
Nov 26, 2024
Member
Sandertv
left a comment
Sandertv
left a comment
There was a problem hiding this comment.
Looks good, no comments other than some suggestions for moving this over to transactions.
DaPigGuy
force-pushed
the
feature/playentityanimation
branch
from
2799a61 to
e1a462b
Compare
DaPigGuy
reviewed
Nov 27, 2024
DaPigGuy
approved these changes
Nov 28, 2024
Sandertv
approved these changes
Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation from #806 with a few changes. I am still undecided whether this deserves to be its own package or if it's something we can move into the entity package and have
entity.NewAnimation(...)