refactor(cli): dedup handle plumbing + progress rendering#134
Merged
Conversation
InspectCommand.describe/open were byte-identical copies of CliHandles .describe/open: promote CliHandles.open to a package-private openTarget and have InspectCommand reuse both, dropping ~30 duplicated lines. renderProgress/clearProgress were duplicated across Export/ImportCommand (clearProgress identical; the determinate bar identical, Import just adds an indeterminate branch). Extract a small ProgressBar helper (render + clear); Export passes ProgressBar::render directly, Import keeps only its indeterminate-row-count branch. Covered by a parameterized ProgressBarTest. No new thin abstraction over the per-command run() boilerplate — left as is. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dfa1
force-pushed
the
refactor/dedup-helpers
branch
from
e5070af to
56408d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two real copy-paste dups in the CLI (no new thin abstractions — the per-command
run()boilerplate is left as-is, it's too thin to wrap).InspectCommand vs CliHandles
InspectCommand.describeandInspectCommand.openwere byte-identical toCliHandles.describe/open. PromotedCliHandles.open→ package-privateopenTargetand pointed InspectCommand at both; ~30 duplicated lines gone (+ trimmed now-unused imports).Export/Import progress
clearProgress()was identical in both; the determinate bar inrenderProgresswas identical (Import just adds an indeterminatetotal < 0branch). Extracted a smallProgressBarhelper (render+clear):ProgressBar::renderdirectly and callsProgressBar.clear().ProgressBar.render.Covered by a parameterized
ProgressBarTest(0/50/100% + non-positive total + clear). Full cli+inspector suites green (181).🤖 Generated with Claude Code