test(cli): render + FilterCommand coverage#58
Merged
Conversation
GridRender: vortex.time (I32 ms), vortex.timestamp (I64 ms) and vortex.uuid (FixedSizeList(U8,16)) extension rendering via the decoder dtype factories. InspectorRender: GenericArray-backed decimal (single-buffer LE mantissa) and the bad-shape fallback path through tryDecimal. Leaves only the DecimalByteParts "null cell" branch uncovered — it needs a masked byte-parts fixture not worth the weight for one return. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add a mixed-type fixture (I64/I32/F64/Utf8) to CliTestSupport and exercise the
previously-uncovered FilterCommand paths:
- parser: Double literal, unknown operator ('!'), empty value, operator at
index 0 (empty column), invalid column name.
- compareValue: Int, Double (compareDouble) and VarBin (lexicographic) columns,
plus compareNumeric's Double branch via a fractional threshold on an I64 column.
Short/Byte/Float/Bool compare branches and the RowFilter.And predicate stay
uncovered — the writer takes no such arrays and the parser emits no AND syntax.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fills untested CLI branches surfaced while chasing the SonarCloud coverage gap. Tests only — no production changes.
GridRender / InspectorRender (
849441a6)vortex.date,vortex.time(I32 ms),vortex.timestamp(I64 ms),vortex.uuid(FixedSizeList(U8,16)).tryDecimal, non-structformatStatsArrayguard.utf8/binaryOffsetMode) inArrayFixtures.FilterCommand (
567f5c8e)!), empty value, operator-at-index-0 (empty column), invalid column name.compareValue: Int / Double (compareDouble) / VarBin (lexicographic) columns +compareNumeric's Double branch.writeTypedVortexinCliTestSupport.Known gaps (intentional)
compareValueShort/Byte/Float/Bool andRowFilter.And— the writer takes no such arrays and the parser emits no AND syntax.DecimalByteParts"null cell" branch — needs a masked byte-parts fixture not worth the weight.🤖 Generated with Claude Code