Skip to content

test(reader): cover DictEncodingDecoder decode paths #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfa1 merged 2 commits into from
Jun 19, 2026
+593 −20
Merged

test(reader): cover DictEncodingDecoder decode paths #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef32f00
test(reader): cover DictEncodingDecoder decode paths
dfa1 Jun 19, 2026
3c6c48a
test(reader): reach 100% line+branch coverage of DictEncodingDecoder
dfa1 Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 4 additions & 20 deletions reader/src/main/java/io/github/dfa1/vortex/reader/decode/DictEncodingDecoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,7 @@ private static Array decodeLegacyJava(DecodeContext ctx, byte codeTypeByte) {
case U8 -> expandU8(codesBuf, valuesBuf, out, rowCount, elemSize);
case U16 -> expandU16(codesBuf, valuesBuf, out, rowCount, elemSize);
case U32 -> expandU32(codesBuf, valuesBuf, out, rowCount, elemSize);
default -> {
for (long i = 0; i < rowCount; i++) {
long code = readCode(codesBuf, codePType, i);
MemorySegment.copy(valuesBuf, code * elemSize, out, i * elemSize, elemSize);
}
}
default -> throw new VortexException(EncodingId.VORTEX_DICT, "unexpected code type: " + codePType);
}
return typedArray(ctx.dtype(), valPType, rowCount, out.asReadOnly());
}
Expand Down Expand Up @@ -166,18 +161,7 @@ private static Array decodeUtf8DictProto(DecodeContext ctx, ByteBuffer metaBuf)
codesBuf, codePType);
}

private static long readCode(MemorySegment buf, PType codePType, long i) {
long cap = SegmentBroadcast.capacity(buf, codePType.byteSize());
long idx = i % cap;
return switch (codePType) {
case U8 -> Byte.toUnsignedLong(buf.get(ValueLayout.JAVA_BYTE, idx));
case U16 -> Short.toUnsignedLong(buf.get(PTypeIO.LE_SHORT, idx * 2));
case U32 -> Integer.toUnsignedLong(buf.get(PTypeIO.LE_INT, idx * 4));
default -> throw new VortexException(EncodingId.VORTEX_DICT, "unexpected code type: " + codePType);
};
}

private static void expandU8(MemorySegment codes, MemorySegment values, MemorySegment out, long rowCount, int elemSize) {
static void expandU8(MemorySegment codes, MemorySegment values, MemorySegment out, long rowCount, int elemSize) {
long codesCap = SegmentBroadcast.capacity(codes, 1);
long valuesCap = SegmentBroadcast.capacity(values, elemSize);
boolean fast = codesCap >= rowCount && valuesCap > 1;
Expand Down Expand Up @@ -250,7 +234,7 @@ private static void expandU8(MemorySegment codes, MemorySegment values, MemorySe
}
}

private static void expandU16(MemorySegment codes, MemorySegment values, MemorySegment out, long rowCount, int elemSize) {
static void expandU16(MemorySegment codes, MemorySegment values, MemorySegment out, long rowCount, int elemSize) {
long codesCap = SegmentBroadcast.capacity(codes, 2);
long valuesCap = SegmentBroadcast.capacity(values, elemSize);
boolean fast = codesCap >= rowCount && valuesCap > 1;
Expand Down Expand Up @@ -323,7 +307,7 @@ private static void expandU16(MemorySegment codes, MemorySegment values, MemoryS
}
}

private static void expandU32(MemorySegment codes, MemorySegment values, MemorySegment out, long rowCount, int elemSize) {
static void expandU32(MemorySegment codes, MemorySegment values, MemorySegment out, long rowCount, int elemSize) {
long codesCap = SegmentBroadcast.capacity(codes, 4);
long valuesCap = SegmentBroadcast.capacity(values, elemSize);
boolean fast = codesCap >= rowCount && valuesCap > 1;
Expand Down
Loading