Skip to content

refactor: document intentionally empty blocks (Sonar S108) #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfa1 merged 1 commit into from
Jun 19, 2026
Merged

refactor: document intentionally empty blocks (Sonar S108) #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cli/src/main/java/io/github/dfa1/vortex/cli/FilterCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,11 @@ private static IllegalArgumentException invalid(String expr) {
private static Comparable<?> parseValue(String raw) {
try {
return Long.parseLong(raw);
} catch (NumberFormatException _) {
} catch (NumberFormatException _) { // not this type; try the next
}
try {
return Double.parseDouble(raw);
} catch (NumberFormatException _) {
} catch (NumberFormatException _) { // not this type; try the next
}
if ("true".equalsIgnoreCase(raw)) {
return Boolean.TRUE;
Expand Down
3 changes: 1 addition & 2 deletions cli/src/main/java/io/github/dfa1/vortex/cli/tui/VortexInspectorTui.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,7 @@ private void handleKey(Key key, List<Item> items) {
case Key.PageUp _ -> selected = Math.max(selected - 10, 0);
case Key.Home _ -> selected = 0;
case Key.End _ -> selected = items.size() - 1;
default -> {
}
default -> { /* ignore unhandled keys */ }
}
}

Expand Down
4 changes: 2 additions & 2 deletions proto-gen/src/main/java/io/github/dfa1/vortex/protogen/TypeRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ private void indexNested(Ast.MessageDecl parent, String parentFqn, String javaPa
String fqn = parentFqn + "." + e.name();
byFqn.put(fqn, new ResolvedType.Enum(e, fqn, javaPackage));
}
case Ast.FieldDecl _ -> { }
case Ast.OneOfDecl _ -> { }
case Ast.FieldDecl _ -> { /* not a type declaration */ }
case Ast.OneOfDecl _ -> { /* not a type declaration */ }
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions reader/src/test/java/io/github/dfa1/vortex/reader/decode/PcoEncodingDecoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ void randomChunkMetaBytes_neverThrowsJvmException(byte[] chunkMetaBytes) {
assertThatCode(() -> {
try {
SUT.decode(ctx);
} catch (VortexException _) {
} catch (VortexException _) { // acceptable; only non-Vortex failures should escape
}
}).doesNotThrowAnyException();
}
Expand All @@ -467,7 +467,7 @@ void randomPageBytes_classicMode_neverThrowsJvmException(byte[] pageBytes) {
assertThatCode(() -> {
try {
SUT.decode(ctx);
} catch (VortexException _) {
} catch (VortexException _) { // acceptable; only non-Vortex failures should escape
}
}).doesNotThrowAnyException();
}
Expand Down