Skip to content

test(reader): reuse TestArrays builders in OffsetArrayTest #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfa1 merged 1 commit into from
Jun 19, 2026
+25 −69
Merged

test(reader): reuse TestArrays builders in OffsetArrayTest #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 25 additions & 69 deletions reader/src/test/java/io/github/dfa1/vortex/reader/array/OffsetArrayTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,101 +144,57 @@ void foldReducesSlicedRange() {
class Bool {
@Test
void getBooleanShiftsByOffset() {
try (Arena arena = Arena.ofConfined()) {
// Given — packed bits [F, T, T, F]
BoolArray inner = boolArray(arena, false, true, true, false);
var sut = new OffsetBoolArray(new DType.Bool(false), 2, inner, 1L);
// Given — bits [F, T, T, F]
BoolArray inner = TestArrays.bools(false, true, true, false);
var sut = new OffsetBoolArray(new DType.Bool(false), 2, inner, 1L);

// When / Then
assertThat(sut.getBoolean(0)).isTrue(); // inner[1]
assertThat(sut.getBoolean(1)).isTrue(); // inner[2]
assertThat(sut.length()).isEqualTo(2);
}
// When / Then
assertThat(sut.getBoolean(0)).isTrue(); // inner[1]
assertThat(sut.getBoolean(1)).isTrue(); // inner[2]
assertThat(sut.length()).isEqualTo(2);
}
}

@Nested
class Int {
@Test
void getIntShiftsByOffset() {
try (Arena arena = Arena.ofConfined()) {
// Given
IntArray inner = intArray(arena, 10, 20, 30, 40);
var sut = new OffsetIntArray(new DType.Primitive(PType.I32, false), 2, inner, 2L);
// Given
IntArray inner = TestArrays.ints(10, 20, 30, 40);
var sut = new OffsetIntArray(new DType.Primitive(PType.I32, false), 2, inner, 2L);

// When / Then
assertThat(sut.getInt(0)).isEqualTo(30);
assertThat(sut.getInt(1)).isEqualTo(40);
}
// When / Then
assertThat(sut.getInt(0)).isEqualTo(30);
assertThat(sut.getInt(1)).isEqualTo(40);
}
}

@Nested
class Long {
@Test
void getLongShiftsByOffset() {
try (Arena arena = Arena.ofConfined()) {
// Given
LongArray inner = longArray(arena, 5L, 6L, 7L, 8L);
var sut = new OffsetLongArray(new DType.Primitive(PType.I64, false), 2, inner, 1L);
// Given
LongArray inner = TestArrays.longs(5L, 6L, 7L, 8L);
var sut = new OffsetLongArray(new DType.Primitive(PType.I64, false), 2, inner, 1L);

// When / Then
assertThat(sut.getLong(0)).isEqualTo(6L);
assertThat(sut.getLong(1)).isEqualTo(7L);
}
// When / Then
assertThat(sut.getLong(0)).isEqualTo(6L);
assertThat(sut.getLong(1)).isEqualTo(7L);
}
}

@Nested
class Double {
@Test
void getDoubleShiftsByOffset() {
try (Arena arena = Arena.ofConfined()) {
// Given
DoubleArray inner = doubleArray(arena, 1.5, 2.5, 3.5);
var sut = new OffsetDoubleArray(new DType.Primitive(PType.F64, false), 2, inner, 1L);
// Given
DoubleArray inner = TestArrays.doubles(1.5, 2.5, 3.5);
var sut = new OffsetDoubleArray(new DType.Primitive(PType.F64, false), 2, inner, 1L);

// When / Then
assertThat(sut.getDouble(0)).isEqualTo(2.5);
assertThat(sut.getDouble(1)).isEqualTo(3.5);
}
}
}

private static BoolArray boolArray(Arena arena, boolean... vs) {
MemorySegment seg = arena.allocate((vs.length + 7) / 8);
for (int i = 0; i < vs.length; i++) {
if (vs[i]) {
long bi = i >>> 3;
byte b = seg.get(ValueLayout.JAVA_BYTE, bi);
seg.set(ValueLayout.JAVA_BYTE, bi, (byte) ((b & 0xff) | (1 << (i & 7))));
}
}
return new MaterializedBoolArray(new DType.Bool(false), vs.length, seg.asReadOnly());
}

private static IntArray intArray(Arena arena, int... vs) {
MemorySegment seg = arena.allocate(vs.length * 4L, 4);
for (int i = 0; i < vs.length; i++) {
seg.setAtIndex(ValueLayout.JAVA_INT, i, vs[i]);
}
return new MaterializedIntArray(new DType.Primitive(PType.I32, false), vs.length, seg.asReadOnly());
}

private static LongArray longArray(Arena arena, long... vs) {
MemorySegment seg = arena.allocate(vs.length * 8L, 8);
for (int i = 0; i < vs.length; i++) {
seg.setAtIndex(ValueLayout.JAVA_LONG, i, vs[i]);
}
return new MaterializedLongArray(new DType.Primitive(PType.I64, false), vs.length, seg.asReadOnly());
}

private static DoubleArray doubleArray(Arena arena, double... vs) {
MemorySegment seg = arena.allocate(vs.length * 8L, 8);
for (int i = 0; i < vs.length; i++) {
seg.setAtIndex(ValueLayout.JAVA_DOUBLE, i, vs[i]);
// When / Then
assertThat(sut.getDouble(0)).isEqualTo(2.5);
assertThat(sut.getDouble(1)).isEqualTo(3.5);
}
return new MaterializedDoubleArray(new DType.Primitive(PType.F64, false), vs.length, seg.asReadOnly());
}

private static ByteArray byteArray(Arena arena, byte... vs) {
Expand Down