Skip to content

fix: pass secrets to test workflow so coverage upload runs#1076

Merged
spoorcc merged 1 commit intomainfrom
claude/fix-coverage-upload-QcTsI
Mar 25, 2026
Merged

fix: pass secrets to test workflow so coverage upload runs#1076
spoorcc merged 1 commit intomainfrom
claude/fix-coverage-upload-QcTsI

Conversation

@spoorcc
Copy link
Copy Markdown
Contributor

@spoorcc spoorcc commented Mar 25, 2026

The test job in ci.yml was missing secrets: inherit, so
CODACY_PROJECT_TOKEN was never available and the coverage upload
step's condition always evaluated to false.

https://claude.ai/code/session_013sZvFxPLqJJzVpiRegohYm

Summary by CodeRabbit

  • Chores
    • Updated CI workflow configuration to enable secret inheritance in testing operations, improving consistency between test and documentation jobs. This ensures proper secret management across automated testing processes.

The test job in ci.yml was missing `secrets: inherit`, so
CODACY_PROJECT_TOKEN was never available and the coverage upload
step's condition always evaluated to false.

https://claude.ai/code/session_013sZvFxPLqJJzVpiRegohYm
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0a3e8e90-765d-4b8f-a202-54305046516b

📥 Commits

Reviewing files that changed from the base of the PR and between e9552f5 and 1bce7f7.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Walkthrough

The .github/workflows/ci.yml file has been updated to add secrets: inherit to the test job configuration. This enables the reusable test workflow to access secrets from the calling workflow, mirroring the configuration pattern already used by the docs job.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/ci.yml
Added secrets: inherit to the test job to allow secret inheritance from the calling workflow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Cleanup CI configs #910 — Modified the test job configuration in .github/workflows/ci.yml, including permissions and job setup that this PR now extends with secrets inheritance.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding secrets: inherit to enable coverage upload in the test workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/fix-coverage-upload-QcTsI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@spoorcc spoorcc merged commit 16fdcdb into main Mar 25, 2026
36 checks passed
@spoorcc spoorcc deleted the claude/fix-coverage-upload-QcTsI branch March 25, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants